Media Source set to 0x0 if transform is being modified when playback ends

[Fenrirthviti]

Expected Behavior

Sources should not be set to 0x0

Current Behavior

When playing back a media source, if you are editing the size or scale of it when playback ends, the size of the source is set to 0x0, meaning that it is no longer visible in the preview.

Steps to Reproduce

1. Add a media source
2. While the source is playing, click and drag the bounding box and hold left mouse
3. Wait for playback to end
4. Bounding box will disappear, and source will be set to 0x0

Video: https://pub.rachni.com/vid/2020-01-10_14-47-43.webm

Additional information

Repro'd 100% of the time on Windows 10 x64, OBS v24.0.3. Oddly, appears that simply moving a source does not trigger this, but changing the size does. I have not tested other platforms.

[Fenrirthviti]

As a side note, confirmed that VLC source has the same issue.

[exeldro]

I could fix this by removing the async_active check in get_base_width and get_base_height (b30c1ed2ef11a968f01179ee8060311f71efec64) That check was added in 506e30da108e7255056b6eb9e91a0ff6297a7951. I don't see any strange behavior, but I'm not sure what this could break.

[PatTheMav]

@Fenrirthviti has this been fixed in the meantime? Because at least on macOS I cannot replicate the issue.

[Fenrirthviti]

This still reproduces on Windows 10 on 26.1

[DocJade]

Had this issue occur a couple days ago on the latest version, fresh install of OBS

I don't have any logs for you, as this happened to a friend of mine whilst he was sharing his screen with me

[Fenrirthviti]

Confirming this is still an issue as of 31.0 Beta1.

[PatTheMav]

@Warchamp7 I guess we'll only really be able to fix this until we make every source always have a bounding box by default, though I'm wary that the "magic" workarounds we still intend to provide in that case might get us right back to this issue again if we're not careful.