obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

libobs: Do not wait for audio of removed sources

Open exeldro opened this issue 3 weeks ago • 0 comments

Description

Do not wait for audio of removed sources

Motivation and Context

Fix #12880 Without this PR obs_transition_stop is not called because transitioning_audio stays true, because the removed scene won't process any more audio the transitioning_audio will never get to false. obs_transition_stop would call obs_source_remove_active_child which deactivates the sources on the deleted scene The VolControl keeps a reference as that UI element is removed on the deactivate signal which does not come The transition keeps a reference as it does not stop, when switching scenes after that it tries to transition from the removed scene every time.

How Has This Been Tested?

On Windows by removing a scene with an audio source and checking if that audio source removes from the mixer when the transition is done.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

exeldro avatar Dec 06 '25 09:12 exeldro