obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard
Published 2 weeks ago • verified publisher icon obsproject

frontend: Fix checked control button color not changing in System theme

Open shiina424 opened this issue 5 months ago • 0 comments

Description

The control button colors do not change in the System theme.
I chose the button colors with consideration for the OS light and dark modes, but I don’t think they are perfect.
Given my current knowledge, it is difficult for me to make any further changes.
If a better solution exists, please feel free to close this PR.

This issue does not occur in version 31.0.4.
It appears to have been caused by the following changes:
https://github.com/obsproject/obs-studio/commit/76e181886699fa77f5ee2564b173b248802b100f and https://github.com/obsproject/obs-studio/commit/28960a48a72f274f9d5306f002c2f4a5500991f3

Before (version 31.0.4) Note: OBS does not switch to dark mode even when the OS is set to dark mode.

https://github.com/user-attachments/assets/daa94e87-9dd3-4448-90f9-3e3e482bbe78

Before (OS Color Light Mode)

https://github.com/user-attachments/assets/c4a9e3cc-6b79-4afd-98aa-984232231070

After (OS Color Light Mode)

https://github.com/user-attachments/assets/6d8612d0-2ea8-4893-a85e-36d5a60684f5

Before (OS Color Dark Mode)

https://github.com/user-attachments/assets/9ad8d4bc-9be8-412d-af1f-4bb613868309

After (OS Color Dark Mode)

https://github.com/user-attachments/assets/6e63e1e4-489e-4c3d-b935-ce4bb7e7e1b2

Motivation and Context

I found a post mentioning that after updating OBS, the control buttons no longer change color. (I’m not sure whether the user was using the System theme.) I’m not sure how many people are using the system theme, but I’ll fix it (even though I don’t use it myself).

How Has This Been Tested?

Windows 11 24H2 Tested in both Windows light and dark modes.

I changed the System.obt file. I’m not sure if the code changes are correct.

You can test by changing the Theme in user.ini to Theme=com.obsproject.System. test_System

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ ] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

shiina424 avatar Jul 26 '25 04:07 shiina424