obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

win-capture: Change WGC capture method name

Open Penwy opened this issue 8 months ago • 7 comments

Description

this changes the localised name of the WGC capture method for display and window capture from Windows 10 (1903 and up) to WGC (Windows 10 1903 and up).

Motivation and Context

Naming the method "Windows 10" frequently confuses users that are on windows 11 and think that, as such, it cannot apply to them. This issue will only worsen with time. The API itself is named "Windows Graphics Capture" so I see no sufficient reason not to use that name.

How Has This Been Tested?

Hasn't.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [ ] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

Penwy avatar Apr 12 '25 23:04 Penwy

I might even be in favor of dropping the part in parenthesis altogether (as those build numbers are typically meaningless to most users). Defer to Warchamp's thoughts though.

Fenrirthviti avatar Apr 12 '25 23:04 Fenrirthviti

The 22H2 as opposed to build number might make more sense as the YYMM format hasn't been used for quite a while. Would it be possible to use "Windows Graphics Capture" and if the user is on an unsupported OS, append " (unavailable, outdated OS)".

notr1ch avatar Apr 13 '25 16:04 notr1ch

That is very much possible, but to note is that the list item is already disabled when not supported. https://github.com/obsproject/obs-studio/blob/master/plugins/win-capture/window-capture.c#L540

Penwy avatar Apr 13 '25 23:04 Penwy

I'd agree the naming needs to be better, what it should be instead is up for debate. @Warchamp7 what do you think?

Lain-B avatar Apr 26 '25 23:04 Lain-B

As I see it there's mainly two questions :

  • Whether to call it WGC or Windows Graphic Capture.
  • Whether to drop the version number (and drop it for BitBlt too) or keep it.

Penwy avatar Apr 27 '25 12:04 Penwy

My vote would be for us to rename both options to Modern (WGC) and Legacy (BitBlt), and also if possible adjust the order to be Automatic, Modern, Legacy

Tangential question: Does the WGC option show up in the list for people on a version earlier than 1903? If so, is it possible for us to hide the option for those people?

@Lain-B

Warchamp7 avatar May 24 '25 17:05 Warchamp7

@Warchamp7 If WGC is not available (for example if on a version of windows too old for it) the option is added to the list but disabled. https://github.com/obsproject/obs-studio/blob/master/plugins/win-capture/window-capture.c#L540

I agree with the suggested name changes, and committed them.

Penwy avatar May 25 '25 14:05 Penwy