obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard
Published 2 weeks ago • verified publisher icon obsproject

UI/themes: Fix missing icon in system theme

Open shiina424 opened this issue 1 year ago • 2 comments

Description

The icons icon-trash, icon-gear, and appearanceIcon are missing. I changed Theme=com.obsproject.Yami.Original to Theme=com.obsproject.System in user.ini to test. I'm not sure if this change is correct, so please close if it's wrong.

Before

https://github.com/user-attachments/assets/bbf8387d-bb5e-436f-9359-7c36d333180e

After

https://github.com/user-attachments/assets/2351acef-de84-41c8-98f6-09ca4e7f080e

Motivation and Context

I want the icons to be displayed correctly.

How Has This Been Tested?

I changed the System.obt file and tested it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ ] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

shiina424 avatar Oct 13 '24 12:10 shiina424

What is the first version of OBS Studio where this is missing?

RytoEX avatar Oct 15 '24 19:10 RytoEX

@RytoEX

appearanceIcon (30.2.0-beta1 / Not added) https://github.com/obsproject/obs-studio/commit/a3a8f6dbfb28f892fcbdc0cd3eaf73a219b5929a

icon-trash , icon-gear (31.0.0-beta1) https://github.com/obsproject/obs-studio/commit/cb026964b00c366943a3c16dfb1511eafc24c035

shiina424 avatar Oct 16 '24 03:10 shiina424

The trash icon should be added to the resource file instead of using the old minus icon. This can be done with Qt Designer which is included in the OBS qt deps

Warchamp7 avatar Oct 21 '24 21:10 Warchamp7