obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

obs-outputs: Add metadata info for enhanced RTMP multivideotracks

Open murillo128 opened this issue 1 year ago • 4 comments

As specified in latest version of the enhanced RTMP spec: https://github.com/veovera/enhanced-rtmp/blob/main/docs/enhanced/enhanced-rtmp-v2.md#enhancing-onmetadata

Motivation and Context

As discussed in https://github.com/veovera/enhanced-rtmp/issues/37 there is currently no way of retrieving the metadata of the enhanced streaming multivideotrack which are not the main one.

The latest of the version has included an extension to the onMetaData object to include that info, and this PR implements it.

How Has This Been Tested?

It has been tested against the millicast rtmp server supporting enhanced streaming

Types of changes

Tweak (non-breaking change to improve existing functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

murillo128 avatar Sep 23 '24 19:09 murillo128

Since the spec has not actually been updated to include these changes (only the draft on a different branch), this PR should also be marked as a draft for now.

derrod avatar Sep 23 '24 19:09 derrod

@derrod fair enough, could it be reviewed even in draft so we can merge it as soon as the new specification is available?

murillo128 avatar Sep 24 '24 08:09 murillo128

The PR of the enhanced RTMP spec has been merged into the main branch of the spec.

murillo128 avatar Oct 01 '24 09:10 murillo128

@derrod ping?

murillo128 avatar Oct 04 '24 07:10 murillo128

the enhanced rtmp containing the change has gone into beta v2-2024-10-22-b1 https://github.com/veovera/enhanced-rtmp/commit/82bfd58e06e5329969bda73d62521aa298b7a18b

murillo128 avatar Oct 24 '24 15:10 murillo128

@derrod the ertmp v2 spec has been finally released

murillo128 avatar Apr 22 '25 17:04 murillo128