FADE TRANSITION CACHES LAST SOURCE

[PeterAkakpo]

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

30.2.3

OBS Studio Version (Other)

No response

OBS Studio Log URL

N/A

OBS Studio Crash Log URL

No response

Expected Behavior

Fade transition should not cache source after transitioning to nullptr;

Current Behavior

when a fade transition transitioned to a nullptr, the transition still caches the last source

Steps to Reproduce

1. create two fade transitions (transition1 and transition2) and two media sources (source1 and source2)
2. set transitions 1 as the output source of channel 0 ->>>>> set_output_source(0, transition1)
3. set transitions 2 as the output source of channel 1 ->>>>> set_output_source(1, transition2)
4. transition to source1 on transition1 ->>>> obs_transition_start(transition1, auto, 500, source1) source1 is visible
5. transition to nullptr on transition1 ->>>> obs_transition_start(transition1, auto, 500, nullptr) source1 is not visible
6. transition to source 2 on transition2 ->>>> obs_transition_start(transition2, auto, 500, source2) source1 is shown for a brief moment before source2 is shown

Anything else we should know?

Further investigation inside the fade transition source code revealed that fade transition use obs_transition_video_render2 which is the culprit because obs_transition_video_render does not do that No response