obsproject
Fails to build against new libajantv2
Operating System Info
Other
Other OS
Clear Linux OS
OBS Studio Version
30.1.2
OBS Studio Version (Other)
No response
OBS Studio Log URL
not in application
OBS Studio Crash Log URL
No response
Expected Behavior
Compiles against libajantv2-17.0.1
Current Behavior
Fails to find header file ntv2linuxdriverinterface.h
Steps to Reproduce
- Compile against system-provided libajantv2
...
Anything else we should know?
Variable names AJA_LIBRARIES_INCLUDE_DIRS, LIBAJANTV2_INCLUDE_DIRS, and LibAJANTV2_INCLUDE_DIRS are used inconsistently in the cmake file, dropping the OS-specific path appends
https://github.com/obsproject/obs-studio/blob/52ae5fc4bd518c67edd8ab94121ace05d9076892/cmake/Modules/FindLibAJANTV2.cmake#L135-L152
from the final list of include directories: https://github.com/obsproject/obs-studio/blob/52ae5fc4bd518c67edd8ab94121ace05d9076892/cmake/Modules/FindLibAJANTV2.cmake#L171
Here is a patch to fix the naming: backport-Fix-AJANTV2-includes-in-backport-patch.patch
cc @paulh-aja @PatTheMav
However, please note that this finder is in the old CMake path, which is deprecated and due for removal.
Also, if you have a proposed patch, submitting a PR would be more appropriate.
Your are trying to compile OBS 30.1.2 against libajantv2 17 ? 30.1.2 only support 16.x.
If this is the case, this is not a bug and neither an issue.
