obsproject
UI: Implement DeleteCookies for YT Service dock
Description
Implement DeleteCookies for YT service integration dock, similar to other service integration docks.
Motivation and Context
This will enable centralized cookie management for YouTube/Google account logins for other browser docks using the shared cookie manager. The existing YouTube Control Panel browser dock will be migrated to using the shared cookie manager (see https://github.com/obsproject/obs-studio/pull/10747) so that sign-in cookies can be shared between YouTube Control Panel and YouTube Live Chat. This will unlock improved creator-facing experience for OBS users of YouTube Live Chat (such as better chat latency, creation end-points for polls, Q&A, moderation capabilities etc).
How Has This Been Tested?
Built OBS locally on Linux workstation, connected YouTube account (via OAuth), disconnected YouTube OAuth, verified no cookies were remaining. For purposes of testing, I copied over cookies from the YTCP cookie manager after logging into YouTube Studio.
Types of changes
- New feature (non-breaking change which adds functionality)
Checklist:
- [x] My code has been run through clang-format.
- [x] I have read the contributing document.
- [x] My code is not on the master branch.
- [x] The code has been tested.
- [x] All commit messages are properly formatted and commits squashed where appropriate.
- [x] I have included updates to all appropriate documentation.
Do not use merge commits to catch up on branch/repo history. Use
git rebase.Do not use final punctuation in PR titles or commit message subjects (the first line of a commit message).
Done.
Do not use final punctuation in PR titles or commit message subjects (the first line of a commit message).
This is still using final punctuation (a period at the end) of the commit message subject.
UI: Implement DeleteCookies for YT Service dock.
This will enable centralized cookie management for YouTube/Google
account logins for other browser docks using the shared cookie manager.
Could you elaborate on how this enables "centralized cookie management for YouTube/Google account logins"?
Do not use final punctuation in PR titles or commit message subjects (the first line of a commit message).
This is still using final punctuation (a period at the end) of the commit message subject.
Done. Fixed, sorry, I did not realize that was disallowed.
UI: Implement DeleteCookies for YT Service dock. This will enable centralized cookie management for YouTube/Google account logins for other browser docks using the shared cookie manager.Could you elaborate on how this enables "centralized cookie management for YouTube/Google account logins"?
Yes, see https://github.com/obsproject/obs-studio/pull/10747. I'm working on another change to improve the chat UX when the user is signed-in, will send the pull request shortly.
Done. Fixed, sorry, I did not realize that was disallowed.
For what it's worth, our Contributing Guidelines cover this in the linked "How to Write a Git Commit Message".
Yes, see #10747. I'm working on another change to improve the chat UX when the user is signed-in, will send the pull request shortly.
Ideally, the context and "why" should be provided here, at least in summary form. If you must point to another PR for additional context, it should be linked in the Motivation section. In this case, this seems more like these changes "enable a future implementation of centralized cookie management" rather than enabling such itself, which was the main point of confusion internally while reviewing this. This by itself only "implements DeleteCookies", and the question brought up in review was, "why?" If you could answer "why?" in the PR's Motivation section, that would be helpful to reviewers.
Yes, see #10747. I'm working on another change to improve the chat UX when the user is signed-in, will send the pull request shortly.
Ideally, the context and "why" should be provided here, at least in summary form. If you must point to another PR for additional context, it should be linked in the Motivation section. In this case, this seems more like these changes "enable a future implementation of centralized cookie management" rather than enabling such itself, which was the main point of confusion internally while reviewing this. This by itself only "implements DeleteCookies", and the question brought up in review was, "why?" If you could answer "why?" in the PR's Motivation section, that would be helpful to reviewers.
Done. Updated the motivation section.
Gentle ping for review, please LMK if the PR's motivation section looks better.