obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

rnnoise: Fix compilation not working on latest gcc

Open cg2121 opened this issue 1 year ago • 1 comments

Description

The latest gcc spits out an error (-Werror=calloc-transposed-args) about calloc parameters that are in the wrong order.

Motivation and Context

I'm on the latest version of Fedora which has the newest gcc and OBS doesn't compile.

How Has This Been Tested?

Compiled OBS

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

cg2121 avatar May 12 '24 02:05 cg2121

Perhaps its time to get rid fo the vendored version as well, afaik we use system packages and obs-deps by default, this is just a fallback that existed because Ubuntu in the ancient times didn't have it.

Edit: It appears it still is ancient times

derrod avatar May 12 '24 09:05 derrod