obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

UI: Update volume meter appearance

Open Warchamp7 opened this issue 3 months ago • 6 comments

Description

Adjusts the layout and appearance of the audio mixer volume controls. Removes minor ticks, dims the decibel indication text, widens the meters for lower channel counts, and adds 10db ticks to the slider.

Before: image

image

After: image

image

Depends on #10602, or at least will prefer to merge that first so that this can be rebased against it.

Motivation and Context

Better use of space, less visual noise.

How Has This Been Tested?

Messed with audio sources and the audio sliders

Types of changes

  • Tweak (non-breaking change to improve existing functionality)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • [x] My code has been run through clang-format.
  • [X] I have read the contributing document.
  • [X] My code is not on the master branch.
  • [X] The code has been tested.
  • [X] All commit messages are properly formatted and commits squashed where appropriate.
  • [X] I have included updates to all appropriate documentation.

Warchamp7 avatar Apr 30 '24 23:04 Warchamp7

I'm not a huge fan of the larger bars and handles, it feels a bit cheap and Fisher Pricey but maybe I need to get used it. The new UI seems a bit cramped with everything so close together. I feel like the icons for properties and mute should also be the same size if they are going next to each other.

notr1ch avatar May 01 '24 00:05 notr1ch

After hearing some responses from broadcast folks, I would suggest adding minor ticks back between -25dBFS and -5dBFS.

tt2468 avatar May 01 '24 01:05 tt2468

I'm not a huge fan of the larger bars and handles, it feels a bit cheap and Fisher Pricey but maybe I need to get used it. The new UI seems a bit cramped with everything so close together. I feel like the icons for properties and mute should also be the same size if they are going next to each other.

I think you'd be hard pressed to find another audio application that has the meters as thin as we used to have them.

The icons are intended to be the same size. There is an open PR to address that inconsistency

After hearing some responses from broadcast folks, I would suggest adding minor ticks back between -25dBFS and -5dBFS.

I'll try to play around with this

Warchamp7 avatar May 01 '24 06:05 Warchamp7

dB font should have a higher contrast maybe give it the same colour as the volume slider? since they're connected?

lextra2 avatar May 02 '24 09:05 lextra2

I'll have to defer to everyone else for discussion about all the details but I feel like colorblind people will definitely appreciate this PR. I also like how it adds the volume level lines to the slider.

Lain-B avatar May 05 '24 00:05 Lain-B

Thoughts on aligning the 3 vertical dots on these red vertical lines instead? Otherwise, looks good! Screenshot 2024-05-05 120225

klemun avatar May 05 '24 10:05 klemun