obsproject
rtmp-services: Add SharePlay.tv
Description
Add SharePlay.tv to rtmp services list.
Motivation and Context
Add support for "SharePlay.tv" in rtmp services.
How Has This Been Tested?
Local Build & CI Build
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
- [x] My code has been run through clang-format.
- [x] I have read the contributing document.
- [x] My code is not on the master branch.
- [x] The code has been tested.
- [x] All commit messages are properly formatted and commits squashed where appropriate.
- [x] I have included updates to all appropriate documentation.
Hi, is this something that we (as SharePlay devs) have to do before the merge is executed? just want to make sure you're not waiting on us for this
Yes, your commit message does not follow our guidelines. It should be something like rtmp-services: Add SharePlay.tv instead.
Please let us know if there are further issues, we'll happily modify as needed.
Hi there, we've updated to the desired formatting. Please let me know if there are any further requirements and we'll rectify it promptly.
@RytoEX @WizardCM @Fenrirthviti Hi guys just checking in to see if everything requested has been met or does our team still needs to do anything else to meet your commit standards.
@Drkcyber @katahtonic @nickg-sp I'd like to ask for a little patience. We're in the middle of beta testing OBS Studio 30.1 as well as many other tasks. Services updates are handled as time allows. This has been assigned to me, so it will get done at some point, but for now my time is prioritized towards OBS Studio 30.1 related tasks. Thank you for your understanding.
Build failure is unrelated. In the future, do not submit multiple commits in a single PR to make additional changes after first submitting. Instead, just amend the existing commit and force push.
Thank you and noted will do that next time.