obs-deps icon indicating copy to clipboard operation
obs-deps copied to clipboard

Remove non-essential Windows x86 deps builds

Open PatTheMav opened this issue 1 year ago • 2 comments

Description

Removes x86 slices of most Windows dependencies, with the exception of Detours and Vulkan, which are both needed for capture plugins.

Motivation and Context

Deprecate all traces of standalone x86 OBS Studio versions.

How Has This Been Tested?

Tested on Windows 11 VM.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

PatTheMav avatar Jun 30 '23 19:06 PatTheMav

Do the first two commits individually work in the absence of the third commit? It looks like they should, but I wanted to confirm.

Commit message nit:

  • detours -> Detours

They should, yeah.

PatTheMav avatar Jun 30 '23 21:06 PatTheMav

Per off-thread discussion, we're going to hold off on merging this change because removing the x86 Windows deps would make doing complete Windows legacy CMake builds of obs-studio a bit burdensome. We'll remove the x86 Windows deps once we remove the legacy CMake.

RytoEX avatar Jul 17 '23 15:07 RytoEX

Can this be merged before #190?

RytoEX avatar Aug 22 '24 20:08 RytoEX

Can this be merged before #190?

Yep, I kinda expected it to even.

PatTheMav avatar Aug 22 '24 21:08 PatTheMav

Let's cut down CI's workload then.

RytoEX avatar Aug 22 '24 21:08 RytoEX