obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

plugin: add RequireJS

Open cstrahan opened this issue 2 years ago • 3 comments

I am submitting a new Community Plugin

Repo URL

https://github.com/cstrahan/obsidian-requirejs/

Release Checklist

  • [ ] I have tested the plugin on
    • [ ] Windows
    • [ ] macOS
    • [x] Linux
    • [ ] Android (if applicable)
    • [ ] iOS (if applicable)
  • [x] My GitHub release contains all required files
    • [x] main.js
    • [x] manifest.json
    • [ ] styles.css (optional)
  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [x] The id in my manifest.json matches the id in the community-plugins.json file.
  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [x] I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • [x] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

cstrahan avatar May 18 '22 02:05 cstrahan

👀 I'm assuming this is meant to say "RequireJS" and not ReactJS

https://github.com/cstrahan/obsidian-requirejs/blob/f2a77c44d7fcb86595a9e4fd3cbcaf32c958f4a9/main.ts#L2 Why so many ts-ignores everywhere?

https://github.com/cstrahan/obsidian-requirejs/blob/f2a77c44d7fcb86595a9e4fd3cbcaf32c958f4a9/main.ts#L82 you have obsidian-dataview as a dependency, you can use the helper functions included in the package for checking if it's installed.

liamcain avatar May 19 '22 03:05 liamcain

@liamcain

Thanks for reviewing!


:eyes: I'm assuming this is meant to say "RequireJS" and not ReactJS

Oops! Yes, that's embarrassing.

cstrahan/obsidian-requirejs@f2a77c4/main.ts#L2 Why so many ts-ignores everywhere?

Because I haven't yet figured out how to pull in type annotations. There's @types/requirejs, but when I tried pulling it in I got a bunch of cryptic (to me) errors from the build system.

This project is the extent of my TypeScript experience, so I have some learning to do :sweat_smile: (and I haven't touched JS build systems in a long time, so that doesn't help either).

I'll see if I can figure out how reduce (or remove entirely) the ts-ignores.

cstrahan/obsidian-requirejs@f2a77c4/main.ts#L82 you have obsidian-dataview as a dependency, you can use the helper functions included in the package for checking if it's installed.

Awesome, I'll give that a go.

cstrahan avatar May 19 '22 04:05 cstrahan

Because I haven't yet figured out how to pull in type annotations. There's @types/requirejs, but when I tried pulling it in I got a bunch of cryptic (to me) errors from the build system.

What are the errors?

liamcain avatar Jun 01 '22 04:06 liamcain

Hi there, to keep things tidy, we're going to temporarily close plugin PRs after a month of inactivity.

Feel free to tell us to re-open it when you're ready to continue. Thanks for your understanding!

ericaxu avatar Nov 09 '22 02:11 ericaxu