obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

Published 20 hours ago • verified publisher icon obsidianmd

Update: add code embed to plugin list

Open Y-jiji opened this issue 2 years ago • 2 comments

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/Y-jiji/code-embed

Release Checklist

  • [x] I have tested the plugin on
    • [x] Windows
  • [x] My GitHub release contains all required files
    • [x] main.js
    • [x] manifest.json
  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [x] The id in my manifest.json matches the id in the community-plugins.json file.
  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [x] I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • [x] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

Y-jiji avatar May 06 '22 14:05 Y-jiji

Click [[Approve and Run]] plz 😀

Y-jiji avatar May 08 '22 13:05 Y-jiji

https://github.com/Y-jiji/code-embed/blob/bf3ee84271cd2f18ea0e49f7451e83c0103ce111/README.md?plain=1#L1 Could you please add more information and maybe a screenshot to your README. I'm sure users will be confused about what this app does when browsing in the Plugin Gallery.

https://github.com/Y-jiji/code-embed/blob/bf3ee84271cd2f18ea0e49f7451e83c0103ce111/main.ts#L5-L11 You can remove these since you don't have any settings

https://github.com/Y-jiji/code-embed/blob/bf3ee84271cd2f18ea0e49f7451e83c0103ce111/main.ts#L20 Also unnecessary

https://github.com/Y-jiji/code-embed/blob/bf3ee84271cd2f18ea0e49f7451e83c0103ce111/main.ts#L57-L62 same here

https://github.com/Y-jiji/code-embed/blob/bf3ee84271cd2f18ea0e49f7451e83c0103ce111/main.ts#L33 You might want to remove the console.log to avoid polluting the console with messages

https://github.com/Y-jiji/code-embed/blob/bf3ee84271cd2f18ea0e49f7451e83c0103ce111/main.ts#L43 you can use .empty() here instead of manipulating the innerHTML

liamcain avatar May 18 '22 03:05 liamcain

Hi, this is the repo for the help documentation of Obsidian, not Obsidian itself.

If you have any feedback about Obsidian, please go to https://forum.obsidian.md instead, thanks!

ericaxu avatar Nov 09 '22 01:11 ericaxu