obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

Add plugin: youtube downloader

Open ai-chen2050 opened this issue 10 months ago • 9 comments

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/ai-chen2050/obsidian-youtube-downloader

Release Checklist

  • [x] I have tested the plugin on
    • [ ] Windows
    • [x] macOS
    • [ ] Linux
    • [ ] Android (if applicable)
    • [ ] iOS (if applicable)
  • [x] My GitHub release contains all required files
    • [x] main.js
    • [x] manifest.json
    • [x] styles.css (optional)
  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [x] The id in my manifest.json matches the id in the community-plugins.json file.
  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • [x] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

ai-chen2050 avatar Apr 20 '24 08:04 ai-chen2050

Hello!

I found the following issues in your plugin submission

Errors:

:x: Unable to find a release with the tag 0.0.1. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Apr 20 '24 08:04 github-actions[bot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:You should not cast this, instead use a instanceof check to make sure that it's actually the adapter you expect.

[1][2][3][4][5][6][7][8][9][10][11][12][13][14]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements


Do NOT open a new PR for re-validation. Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours. If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

ObsidianReviewBot avatar Apr 21 '24 03:04 ObsidianReviewBot

Changes requested by bot have been made, assigning human for additional review.

ObsidianReviewBot avatar Apr 21 '24 06:04 ObsidianReviewBot

Hello!

I found the following issues in your plugin submission

Errors:

:x: Plugin name mismatch, the name in this PR (youtube downloader) is not the same as the one in your repo (YouTube Downloader). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Apr 22 '24 11:04 github-actions[bot]

Hello!

I found the following issues in your plugin submission

Errors:

:x: Plugin name mismatch, the name in this PR (youtube downloader) is not the same as the one in your repo (YouTube Downloader). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Apr 22 '24 11:04 github-actions[bot]

Hi, @joethei, All request changes has been addressed. Please see the latest code.

ai-chen2050 avatar Apr 22 '24 12:04 ai-chen2050

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

github-actions[bot] avatar Jun 30 '24 07:06 github-actions[bot]

Hi, there. update

ai-chen2050 avatar Jun 30 '24 08:06 ai-chen2050

There are still 4 places where the capitalization of YouTube is not correct.

joethei avatar Jul 15 '24 11:07 joethei

Thx @joethei for pointing that out, I had been addressed issues about incorrect spelling of YouTube

ai-chen2050 avatar Jul 25 '24 07:07 ai-chen2050