Add plugin: Open in Marked

[ttscoff]

Add Marked 2 to community plugins

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/ttscoff/Marked2-obsidian

Release Checklist

• [x] I have tested the plugin on
  • [ ] Windows
  • [x] macOS
  • [ ] Linux
  • [ ] Android (if applicable)
  • [ ] iOS (if applicable)
• [x] My GitHub release contains all required files
  • [x] main.js
  • [x] manifest.json
  • [ ] styles.css (optional)
• [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• [x] The id in my manifest.json matches the id in the community-plugins.json file.
• [x] My README.md describes the plugin's purpose and provides clear usage instructions.
• [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• [x] I have added a license in the LICENSE file.
• [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

[github-actions[bot]]

Hello!

I found the following issues in your plugin submission

Errors:

:x: The plugin ID is not valid. Only alphanumeric characters and dashes are allowed. :x: Plugin name mismatch, the name in this PR (Open in Marked 2) is not the same as the one in your repo (Open in Marked). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[github-actions[bot]]

Hello!

I found the following issues in your plugin submission

Errors:

:x: Plugin ID mismatch, the ID in this PR (marked-obsidian) is not the same as the one in your repo (Marked-obsidian). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.

---

Do NOT open a new PR for re-validation. Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours. If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[ObsidianReviewBot]

Changes requested by bot have been made, assigning human for additional review.

[ObsidianReviewBot]

Changes requested by bot have been made, assigning human for additional review.

[joethei]

MIT License This license is missing the year and author information

"child_process": "^1.0.2", These two dependencies are part of Node, they can't be installed through NPM, remove this

"minAppVersion": "0.9.12", You are using newer API's, set this to the latest public build number.

const { exec } = require('child_process') Stick to one import style.

return false;, return false; This means that your commands will never be available, better would be return Platform.isMacOS; so that the command is only available on a Mac. Also check this before adding the Ribbon icon to make sure it's only visible when running the plugin on a Mac.

new Notice("No active pane. Try again with a note open."); And add a check that activeFile !== undefined to the checkCallback here instead of this notice.

containerEl.createEl('h2', { text: 'Open in Marked' }); Don't include a header with the plugin name in the settings

[github-actions[bot]]

Hello!

I found the following issues in your plugin submission

Errors:

:x: Your latest Release is missing the main.js file.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[ttscoff]

Was accidentally attaching ts instead of js file to release, this has been fixed in release 1.1.1.

[ttscoff]

I assume you'll resolve the conflicts that arose because new plugins have been added since this release was created? Tried to resolve conflict unsuccessfully.

[ttscoff]

Also check this before adding the Ribbon icon to make sure it's only visible when running the plugin on a Mac.

missed this one on the first deploy, 1.1.3 has it. Also avoids adding settings at all if not macOS because the only setting is the ribbon icon color.

[ttscoff]

Bump… do I need to fix the merge conflict? @joethei

[joethei]

No, I'll do that before merging

[ttscoff]

I think I've satisfied all change requests, any ETA on getting this into the Community plugins?

[ttscoff]

Bump. Any hope of getting this live?

[github-actions[bot]]

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

[ttscoff]

What's holding up this plugin submission? @joethei

[github-actions[bot]]

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

[github-actions[bot]]

Hi there, to keep things tidy, we're closing PRs after one and a half months of inactivity. Feel free to create a new pull request when you're ready to continue. Thanks for your understanding!