obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

Add plugin: Légifrance Intégration

Open carnetdethese opened this issue 10 months ago • 8 comments

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/carnetdethese/obsidian-legifrance-integration

Release Checklist

  • [ ] I have tested the plugin on
    • [ ] Windows
    • [x] macOS
    • [ ] Linux
    • [ ] Android (if applicable)
    • [ ] iOS (if applicable)
  • [x] My GitHub release contains all required files
    • [x] main.js
    • [x] manifest.json
    • [x] styles.css (optional)
  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [x] The id in my manifest.json matches the id in the community-plugins.json file.
  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • [x] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

carnetdethese avatar Apr 15 '24 10:04 carnetdethese

Hello!

I found the following issues in your plugin submission

Errors:

:x: Please don't use the word obsidian in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting. :x: Plugin ID mismatch, the ID in this PR (obsidian-legifrance-integration) is not the same as the one in your repo (obisidian-legifrance-integration). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release. :x: Plugin name mismatch, the name in this PR (Legifrance Integration) is not the same as the one in your repo (Légifrance Intégration). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Apr 15 '24 10:04 github-actions[bot]

Hello!

I found the following issues in your plugin submission

Errors:

:x: Plugin ID mismatch, the ID in this PR (legifrance-integration) is not the same as the one in your repo (obisidian-legifrance-integration). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Apr 15 '24 10:04 github-actions[bot]

Hello!

I found the following issues in your plugin submission

Errors:

:x: Plugin ID mismatch, the ID in this PR (legifrance-integration) is not the same as the one in your repo (obisidian-legifrance-integration). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Apr 15 '24 10:04 github-actions[bot]

Hello!

I found the following issues in your plugin submission

Errors:

:x: Unable to find a release with the tag 1.0.4. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Apr 15 '24 10:04 github-actions[bot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove anything from the sample plugin that you don't need.


Do NOT open a new PR for re-validation. Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours. If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

ObsidianReviewBot avatar Apr 16 '24 03:04 ObsidianReviewBot

Changes requested by bot have been made, assigning human for additional review.

ObsidianReviewBot avatar Apr 16 '24 12:04 ObsidianReviewBot

"minAppVersion": "0.15.0", You are using newer API's, set this to the latest public build number.

"description": "Module d'intégration de l'API Légifrance dans l'environnement de travail Obsidian.", Avoid including sentences like "This is a plugin for Obsidian that does ..." in your description, it should be self-evident that this is a plugin for Obsidian. We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple.

// Remember to rename these classes and interfaces! Remove this comment.

this.addRibbonIcon('scale', 'Légifrance intégration', async (evt: MouseEvent) => {, return "Légifrance Intégration";, container.createEl("h4", { text: "Légifrance Intégration" }); Remove intégration here.

const Mustache = require('mustache');, const node_fetch_1 = require("node-fetch"); Stick to one style for imports.

const data = await node_fetch_1.default(url, { This should also be using requestUrl

joethei avatar Apr 17 '24 12:04 joethei

Thanks for your comments. I just commited the changes! Hope it is better ;)

carnetdethese avatar Apr 17 '24 14:04 carnetdethese

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

github-actions[bot] avatar May 18 '24 07:05 github-actions[bot]

Hi there! I added the changes a while ago, is it possible to integrate the plugin?

carnetdethese avatar May 21 '24 11:05 carnetdethese

Hello!

I found the following issues in your plugin submission

Errors:

:x: Plugin name mismatch, the name in this PR (Legifrance Integration) is not the same as the one in your repo (Légifrance Intégration). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar May 22 '24 18:05 github-actions[bot]