obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

Add plugin: Ayanite

Open jemstelos opened this issue 11 months ago • 11 comments

I am submitting a new Community Plugin

I've granted access to the full repository source code, and written up a detailed walkthrough for the Obsidian team reviewers. Please let me know if there's anything else required for the review process.

Link to my plugin: https://github.com/jemstelos/ayanite (placeholder)

Release Checklist

  • [x] I have tested the plugin on
    • [ ] Windows
    • [x] macOS
    • [ ] Linux
    • [ ] Android (if applicable)
    • [ ] iOS (if applicable)
  • [x] My GitHub release contains all required files
    • [x] main.js
    • [x] manifest.json
    • [ ] styles.css (optional)
  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [x] The id in my manifest.json matches the id in the community-plugins.json file.
  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • [ ] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

jemstelos avatar Mar 15 '24 02:03 jemstelos

Hello!

I found the following issues in your plugin submission

Warnings:

:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Mar 15 '24 02:03 github-actions[bot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to.

[1][2]:Please remove anything from the sample plugin that you don't need.

[1]:Adding command to the command ID is not necessary, please remove it.


Do NOT open a new PR for re-validation. Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours. If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

ObsidianReviewBot avatar Mar 16 '24 03:03 ObsidianReviewBot

/skip these should not be relevant as they are on the sample plugin placeholder.

@joethei please let me know if you have everything you need for the review!

jemstelos avatar Mar 18 '24 05:03 jemstelos

Changes requested by bot have been made, assigning human for additional review.

ObsidianReviewBot avatar Mar 18 '24 06:03 ObsidianReviewBot

You should remove the sample plugin from the public repo, the only files that should be there are: manifest.json, and versions.json

Also, the release needs to contain your actual plugin release, not the sample plugin.

Your README is missing a lot of information how to use the plugin.

"description": "A powerful AI chat interface for leveraging GPT models in an integrated learning environment", The description needs to include "(Closed source)"

All other issues have been left in an issue on the repo.

joethei avatar Mar 18 '24 10:03 joethei

Hello!

I found the following issues in your plugin submission

Warnings:

:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Apr 08 '24 06:04 github-actions[bot]

Hey @joethei! I cleaned up unused code files, updated the README and manifest, and created a new release with plugin release. I also addressed all comments from your issue review. Please let me know if there are any additional actions required!

jemstelos avatar Apr 08 '24 07:04 jemstelos

Hi @joethei, hoping to bump this up for your review as it's been a while from the initial push! Thank you in advance!

jemstelos avatar Apr 15 '24 05:04 jemstelos

Hello!

I found the following issues in your plugin submission

Warnings:

:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar May 10 '24 17:05 github-actions[bot]

Hello!

I found the following issues in your plugin submission

Warnings:

:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar May 10 '24 17:05 github-actions[bot]

@joethei apologies for the confusion, I've reopened this original pull request as per your guidance. Thank you again!

jemstelos avatar May 10 '24 17:05 jemstelos

hey @joethei, the code changes from your review have been addressed and are ready to review. thank you!

jemstelos avatar May 20 '24 03:05 jemstelos

Sorry for the delay!

joethei avatar Jun 06 '24 16:06 joethei

Hello!

I found the following issues in your plugin submission

Warnings:

:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Jun 06 '24 16:06 github-actions[bot]