obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

Add plugin: Ego Rock

Open echo-bravo-yahoo opened this issue 1 year ago • 1 comments

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/echo-bravo-yahoo/ego-rock/

Release Checklist

  • [x] I have tested the plugin on
    • [x] Windows
    • [x] macOS
    • [x] Linux
    • [x] Android (if applicable) [not applicable; plugin is marked as desktop only]
    • [x] iOS (if applicable) [not applicable; plugin is marked as desktop only]
  • [x] My GitHub release contains all required files
    • [x] main.js
    • [x] manifest.json
    • [x] styles.css (optional)
  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [x] The id in my manifest.json matches the id in the community-plugins.json file.
  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • [x] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

echo-bravo-yahoo avatar Feb 22 '24 18:02 echo-bravo-yahoo

Hello!

I found the following issues in your plugin submission

Errors:

:x: Could not parse community-plugins.json, invalid JSON. Unexpected token ] in JSON at position 373167


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Feb 22 '24 18:02 github-actions[bot]

"fundingUrl": "https://blog.echobravoyahoo.net", This is meant for links to services like Buy me a coffee, GitHub sponsors and so on, if you don't have such a link omit this.

import { parse } from 'yaml' Use the parseYaml function from the Obsidian API instead of importing an additional dependency.

this.addRibbonIcon('dice', 'Task lookup', () => { Use a different icon: https://docs.obsidian.md/Plugins/User+interface/Icons

console.log(newCommand), console.log(newCommand) Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

joethei avatar Feb 28 '24 17:02 joethei

@joethei Hey Johannes - thanks for the timely review! Version 2.0.0 should address your feedback; you can find the release here and the diff of 2.0.0 and 1.0.2 (which you reviewed prior) here.

echo-bravo-yahoo avatar Feb 28 '24 19:02 echo-bravo-yahoo