Add plugin: Alias Management

[WithMarcel]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/WithMarcel/alias-management

Release Checklist

• [x] I have tested the plugin on
  • [x] Windows
  • [ ] macOS
  • [x] Linux
  • [ ] Android (if applicable)
  • [ ] iOS (if applicable)
• [x] My GitHub release contains all required files
  • [x] main.js
  • [x] manifest.json
  • [x] styles.css (optional)
• [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• [x] The id in my manifest.json matches the id in the community-plugins.json file.
• [x] My README.md describes the plugin's purpose and provides clear usage instructions.
• [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• [x] I have added a license in the LICENSE file.
• [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

---

[1][2]:You should not cast this, instead use a instanceof check to make sure that it's actually a file/folder

[1]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements

[1][2]:Adding command to the command ID is not necessary, please remove it.

---

Do NOT open a new PR for re-validation. Once you have pushed all of the required changes, the bot will reevaluate your PR within 6 hours. If you think some of these results are incorrect, please include /skip in your comment and the reason why you think the results are incorrect.

[WithMarcel]

The changes were made 17 hours ago. Is there a chance to retrigger the bot? @joethei

[joethei]

The way you have updated the code in your repo has broken the bot, it relies on the commit with the bad code to still exist.

The bot will rescan your code soon.

[joethei]

const plugin = this.app.plugins.plugins[PluginIdentifier], let file = this.app.vault.getAbstractFileByPath(fpath), file = this.app.vault.getAbstractFileByPath(fpath_old), const plugin = this.app.plugins.plugins[PluginIdentifier], const plugin = this.app.plugins.plugins[PluginIdentifier], const plugin = this.app.plugins.plugins[PluginIdentifier], const plugin = this.app.plugins.plugins[PluginIdentifier], const leaves = this.app.workspace.getLeavesOfType(DuplicateAliasesViewIdentifier), const plugin = this.app.plugins.plugins[PluginIdentifier], const leaves = this.app.workspace.getLeavesOfType(ListAliasesViewIdentifier), const leaves = this.app.workspace.getLeavesOfType(DuplicateAliasesViewIdentifier), const plugin = this.app.plugins.plugins[PluginIdentifier], const settings = this.app.plugins.plugins[PluginIdentifier].settings, const plugin = this.app.plugins.plugins[PluginIdentifier], const plugin = this.app.plugins.plugins[PluginIdentifier], const plugin = this.app.plugins.plugins[PluginIdentifier], const plugin = this.app.plugins.plugins[PluginIdentifier], const file = this.app.vault.getAbstractFileByPath(fpath), this.app.workspace.iterateAllLeaves((leaf: WorkspaceLeaf) => {, const settings = this.app.plugins.plugins[PluginIdentifier].settings and more. this doesn't exist, you're in a top level function. This is likely defaulting to the global obj which is an anti-pattern. Instead pass over the plugin instance into your function, and then use this.plugin or this.plugin.app to access these functions.

target_leaf = this.app.workspace.getUnpinnedLeaf() This function is deprecated, use this.app.workspace.getLeaf(false) instead.

[WithMarcel]

Thank you very much for your suggestions. I have implemented them.