obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

Add plugin: Select & Complete

Open macro21KGB opened this issue 1 year ago • 3 comments

I am submitting a new Community Plugin

Repo URL

Link to my plugin:

Release Checklist

  • [x] I have tested the plugin on
    • [x] Windows
    • [x] macOS
    • [x] Linux
    • [ ] Android (if applicable)
    • [ ] iOS (if applicable)
  • [x] My GitHub release contains all required files
    • [x] main.js
    • [x] manifest.json
    • [x] styles.css (optional)
  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [x] The id in my manifest.json matches the id in the community-plugins.json file.
  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • [x] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

macro21KGB avatar Feb 15 '24 19:02 macro21KGB

Hello!

I found the following issues in your plugin submission

Errors:

:x: The plugin ID is not valid. Only alphanumeric characters and dashes are allowed. :x: Plugin ID mismatch, the ID in this PR (select-and-complete,) is not the same as the one in your repo (select-and-complete). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Feb 15 '24 19:02 github-actions[bot]

the url for this plugin is: https://github.com/macro21KGB/select-and-complete

macro21KGB avatar Feb 16 '24 14:02 macro21KGB

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove anything from the sample plugin that you don't need.


Optional

[1]:Obsidian provides the requestUrl method, it will make sure that network requests work on every plattform.

[1]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation. Once you have pushed all of the required changes, the bot will reevaluate your PR within 6 hours. If you think some of these results are incorrect, please include /skip in your comment and the reason why you think the results are incorrect.

ObsidianReviewBot avatar Feb 17 '24 03:02 ObsidianReviewBot

id: 'sc_complete_text', Don't prefix the command id with the plugin id, Obsidian will make sure that there are no conflicts with other plugins.

name: 'Complete Text', Use sentence case in UI

.setName('OPENAI API Key') use the proper capitalization.

joethei avatar Feb 27 '24 20:02 joethei