obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

Add plugin: Cards View

Open jillro opened this issue 1 year ago • 2 comments

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/jillro/obsidian-cards-view-plugin/

Release Checklist

  • [X] I have tested the plugin on
    • [x] Windows
    • [x] macOS
    • [X] Linux
    • [x] Android (if applicable)
    • [ ] iOS (if applicable)
  • [X] My GitHub release contains all required files
    • [X] main.js
    • [X] manifest.json
    • [X] styles.css (optional)
  • [X] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [X] The id in my manifest.json matches the id in the community-plugins.json file.
  • [X] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [X] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • [X] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • [X] I have added a license in the LICENSE file.
  • [X] My project respects and is compatible with the original license of any code from other plugins that I'm using.
  • [X] I have given proper attribution to these other projects in my README.md.

jillro avatar Jan 20 '24 20:01 jillro

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

[1]:You should not cast this, instead use a instanceof check to make sure that it's actually a file/folder

(skipped)


Do NOT open a new PR for re-validation. Once you have pushed all of the required changes, the bot will reevaluate your PR within 6 hours. If you think some of these results are incorrect, please include /skip in your comment and the reason why you think the results are incorrect.

ObsidianReviewBot avatar Jan 21 '24 03:01 ObsidianReviewBot

/skip I fixed the first one, but there is no other way to do this for the second one.

jillro avatar Jan 21 '24 20:01 jillro

Required

export const VIEW_TYPE = "cards-view-plugin"; Remove the plugin suffix.

return this.app.vault.getName(); This should not use the vault name, it should be the plugin name.


Optional

"author": "Maud Royer [email protected]", This field is displayed in the sidebar and in the description for the plugin details page. Are you sure you want to have your email listed so prominently? image

joethei avatar Feb 26 '24 11:02 joethei

@joethei changes done, thanks for your feedback.

jillro avatar Mar 01 '24 15:03 jillro

Hello!

I found the following issues in your plugin submission

Errors:

:x: Unable to find a release with the tag 1.2.3. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Mar 01 '24 19:03 github-actions[bot]