obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

Add plugin: Free Spaced Repetition

Open JYC333 opened this issue 1 year ago • 4 comments

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/JYC333/osbidian-free-spaced-repetition

Release Checklist

  • [x] I have tested the plugin on

  • [x] Windows

  • [ ] macOS

  • [ ] Linux

  • [ ] Android (if applicable)

  • [ ] iOS (if applicable)

  • [x] My GitHub release contains all required files

  • [x] main.js

  • [x] manifest.json

  • [x] styles.css (optional)

  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)

  • [x] The id in my manifest.json matches the id in the community-plugins.json file.

  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.

  • [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.

  • [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.

  • [x] I have added a license in the LICENSE file.

  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

JYC333 avatar Dec 23 '23 22:12 JYC333

Hello!

I found the following issues in your plugin submission

Errors:

:x: Please don't use the word obsidian in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting. :x: Plugin name mismatch, the name in this PR (Free Spaced Repetition) is not the same as the one in your repo (Obsidian Free Spaced Repetition). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


Warnings:

:warning: The authorUrl field in your manifest should not point to the GitHub repository of the plugin. :warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Dec 23 '23 22:12 github-actions[bot]

Hello!

I found the following issues in your plugin submission

Warnings:

:warning: The authorUrl field in your manifest should not point to the GitHub repository of the plugin. :warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

github-actions[bot] avatar Dec 23 '23 23:12 github-actions[bot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

[1]:Obsidian's configuration directory isn't necessarily .obsidian, it can be configured by the user. You can access the configured value from Vault#configDir

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more:You should consider limiting the number of console.logs in your code, to not pollute the dev console.


Do NOT open a new PR for re-validation. If you think some of these results are incorrect, please include /skip in your comment and the reason why you think the results are incorrect. Once you have pushed all of the required changes, the bot will reevaluate your PR within 4 hours.

ObsidianReviewBot avatar Jan 02 '24 09:01 ObsidianReviewBot

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 30 days unless there are any updates.

github-actions[bot] avatar Feb 02 '24 07:02 github-actions[bot]

Hi there, to keep things tidy, we're closing PRs after some inactivity. Feel free to create a new pull request when you're ready to continue.

Thanks for your understanding!

joethei avatar Mar 01 '24 18:03 joethei