obsidian-releases
obsidian-releases copied to clipboard
Add plugin: Wechat Public Platform
new plugin
I am submitting a new Community Plugin
Obsidian Wechat public Plugin is a plugin to release article from your Obsidian Vault.
Repo URL
Link to my plugin: https://github.com/ai-chen2050/obsidian-wechat-public-platform
Release Checklist
- [x] I have tested the plugin on
- [ ] Windows
- [x] macOS
- [ ] Linux
- [ ] Android (if applicable)
- [ ] iOS (if applicable)
- [x] My GitHub release contains all required files
- [x]
main.js
- [x]
manifest.json
- [ ]
styles.css
(optional)
- [x]
- [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix
v
) - [x] The
id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file. - [x] My README.md describes the plugin's purpose and provides clear usage instructions.
- [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
- [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
- [x] I have added a license in the LICENSE file.
- [x] My project respects and is compatible with the original license of any code from other plugins that I'm using.
I have given proper attribution to these other projects in my
README.md
.
Hello!
I found the following issues in your plugin submission
Errors:
:x: Could not parse community-plugins.json
, invalid JSON. Unexpected token ] in JSON at position 358558
This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.
Hello!
I found the following issues in your plugin submission
Errors:
:x: Could not parse community-plugins.json
, invalid JSON. Unexpected token ] in JSON at position 358558
This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.
Hello!
I found the following issues in your plugin submission
Errors:
:x: Please don't use the word plugin
in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
:x: Plugin ID mismatch, the ID in this PR (wechat-public-plugin
) is not the same as the one in your repo (Wepublic-plugin
). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
:x: The authorUrl
field in your manifest should not point to the Obsidian Website. If you don't have a website you can just point it to your GitHub profile.
:x: The fundingUrl
field in your manifest should not point to the Obsidian Website, If you don't have a link were users can donate to you, you can just omit this.
:x: Unable to find a release with the tag 0.17.0
. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.
Warnings:
:warning: Please don't use the word Plugin
in the plugin name since it's redundant and adds clutter to the plugin list.
:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.
This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.
Hello!
I found the following issues in your plugin submission
Errors:
:x: Please don't use the word plugin
in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
:x: Plugin ID mismatch, the ID in this PR (wechat-public-plugin
) is not the same as the one in your repo (Wepublic-plugin
). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
:x: The authorUrl
field in your manifest should not point to the Obsidian Website. If you don't have a website you can just point it to your GitHub profile.
:x: The fundingUrl
field in your manifest should not point to the Obsidian Website, If you don't have a link were users can donate to you, you can just omit this.
:x: Unable to find a release with the tag 0.17.0
. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.
Warnings:
:warning: Please don't use the word Plugin
in the plugin name since it's redundant and adds clutter to the plugin list.
:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.
This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.
Hello!
I found the following issues in your plugin submission
Errors:
:x: Plugin ID mismatch, the ID in this PR (wechat-public-publish
) is not the same as the one in your repo (Wepublic-plugin
). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
:x: The authorUrl
field in your manifest should not point to the Obsidian Website. If you don't have a website you can just point it to your GitHub profile.
:x: The fundingUrl
field in your manifest should not point to the Obsidian Website, If you don't have a link were users can donate to you, you can just omit this.
:x: Unable to find a release with the tag 0.17.0
. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.
Warnings:
:warning: Please don't use the word Plugin
in the plugin name since it's redundant and adds clutter to the plugin list.
:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.
This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.
Hello!
I found the following issues in your plugin submission
Errors:
:x: Please don't use the word obsidian
in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
:x: Please don't use the word Obsidian
at the start of your plugin name since it's redundant and makes it harder to sort the plugin list.
:x: Your latest version number is not valid. Only numbers and dots are allowed.
Warnings:
:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.
This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.
Thank you for your submission, an automated scan of your plugin code's revealed the following issues:
[2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18]:You should change all instances of var
to either const
or let
. var
has function-level scope, so it can easily lead to bugs if you're not careful. Here's a pretty good guide with examples of why not to use var
: why var
is obsolete
[1][2]:Using innerHTML
, outerHTML
or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements
(skipped)
[1]:Casting to any
should be avoided as much as possible.
Do NOT open a new PR for re-validation. If you think some of these results are incorrect, please include /skip
in your comment and the reason why you think the results are incorrect.
Once you have pushed all of the required changes, the bot will reevaluate your PR within 4 hours.
update
Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 30 days unless there are any updates.
Halo, Is there anybody here, @muness @czottmann
You have not addressed all the things the bot has flagged.
They contain user input, that is extremely risky.
have some suggestions? @joethei , bro. I just learning from other plugins.
I create new elements using document.createElement and set their text content using textContent. Instead of directly using innerHTML.
how to trigger the bot action scan again, still needs ? @joethei
Wait, the bot runs on a timer
hello, bro. Its seem that bot isn't scam after four hours @joethei , what's going on?
Copyright (c) 2021 jsonmartin Fill this with the correct information.
"description": "Obsidian Wechat public Plugin is a plugin to release article from your Obsidian Vault.", Avoid including sentences like "This is a plugin for Obsidian that does ..." in your description, it should be self-evident that this is a plugin for Obsidian. We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple.
interface WeChatPublicSettings { Remove this code.
id: 'send-all-fans-by-wechatpublic-plugin',, id: 'release-article-by-wechatpublic-plugin',, id: 'add-draft-by-wechatpublic-plugin',, id: 'upload-material-by-wechatpublic-plugin',, id: 'download-material-from-wechatpublic',
Remove the -by-wechatpublic-plugin
suffix, Obsidian will make sure that there are no conflicts with other plugins.
name: 'Send to all fans by WeChatPublic plugin【 normal account one shot a day 】',, name: 'Release article by WeChatPublic plugin',, name: 'add draft by WeChatPublic plugin',, name: 'upload material by WeChatPublic plugin.', Remove the `by WeChatPublic plugin´ text, it's unnecessary duplication, items in the command pallete will already be prefixed by the plugin name.
name: 'Send to all fans by WeChatPublic plugin【 normal account one shot a day 】', I also think that the word "fans" is incorrect here,
async loadFrontMatter(file: TFile): Promise<FrontMatter> {
Use <appInstance>.metadataCache.getFileCache(file).frontmatter
instead of this function.
async storeFrontMatter(file: TFile, fm: FrontMatter) {
use the processFrontMatter
function instead: https://github.com/obsidianmd/obsidian-api/blob/master/CHANGELOG.md#new-metadata-api
// 读取值 Remove these two functions and use the API's recommended above instead.
contentEl.createEl("h1", { text: "Input Youtube Video Source" });, .setDesc("video-url: 视频链接") You should be consistent with the language used, some text is in english and some is in Chinese.
contentEl.createEl("h1", { text: "Input Youtube Video Source" });, contentEl.createEl("h1", { text: "Input Download Details" });, .setName('NoteLocationFolder'), .setName('DownloadFolder'), .setName('YoutubeSaveFolder'), and more Use sentence case in UI
containerEl.createEl('h2', { text: '🌈 Wechat Public Platform Settings'}); Don't include a header with the plugin name in the settings
containerEl.createEl('h2', { text: '🌎 🌞 Baidu Bjh Platform Settings 🔍'});, containerEl.createEl('h2', { text: '👉 📺 Youtube Downloader Settings'}); Avoid "settings" in settings headings
background: url(https://s2.loli.net/2022/01/11/XyHnMBGWCl5Z9DK.png);, img3.src = 'https://github.com/ai-chen2050/obsidian-wechat-public-platform/raw/master/public/commutity.jpg';, img4.src = 'https://github.com/ai-chen2050/obsidian-wechat-public-platform/raw/master/public/wechat-motion-qr.png'; As part of our developer policies, it is not allowed to load remote resources for styling purposes, you need to encode these with base64, if you want them to be included.
img3.src = 'https://github.com/ai-chen2050/obsidian-wechat-public-platform/raw/master/public/commutity.jpg'; Also, there should be no animations like this inside of the settings tab.
The download feature for youtube videos makes no sense in this plugin and should be removed.
@joethei thinks you, bro. I have almost updated all of your suggestions. I need the feature about youtube videos, which may be needed for others. so I want to keep this feature and leave. I hope you could understand. Thx again.
Have a good day!
@joethei thinks you, bro. I have almost updated all of your suggestions. I need the feature about youtube videos, which may be needed for others. so I want to keep this feature and leave. I hope you could understand. Thx again.
Have a good day! 😄
@joethei Halo, bro. I have addressed all suggestions.
containerEl.createEl('h2', { text: '🌈 Wechat Public Platform Zone'});, containerEl.createEl('h2', { text: '🌎 🌞 Baidu Bjh Platform Zone 🔍'});, containerEl.createEl('h2', { text: '👉 📺 Youtube Downloader Zone'});, .setButtonText('Copy Cookie'), containerEl.createEl('h2', { text: '💰 Support 支持 & Funding 赞助 💰'}); Use sentence case in UI and for section headings in settings use:
new Setting(containerEl).setName('name here').setHeading();
.setName('NoteLocationFolder'), .setName('DownloadFolder'), .setName('YoutubeSaveFolder') Use sentence case as above, and add some spaces.
containerEl.createEl('h2', { text: '🌈 Wechat Public Platform Zone'});, containerEl.createEl('h2', { text: '🌎 🌞 Baidu Bjh Platform Zone 🔍'});, containerEl.createEl('h2', { text: '👉 📺 Youtube Downloader Zone'});, .setButtonText('Copy Cookie'), containerEl.createEl('h2', { text: '💰 Support 支持 & Funding 赞助 💰'}); Use sentence case in UI and for section headings in settings use:
new Setting(containerEl).setName('name here').setHeading();
.setName('NoteLocationFolder'), .setName('DownloadFolder'), .setName('YoutubeSaveFolder') Use sentence case as above, and add some spaces.
.setName('Blacklist') Stick to one language, the name is english while the description is chinese.
Fixed again, bro. Have a good day.
containerEl.createEl('h2', { text: '🌈 Wechat Public Platform Zone'});, containerEl.createEl('h2', { text: '🌎 🌞 Baidu Bjh Platform Zone 🔍'});, containerEl.createEl('h2', { text: '👉 📺 Youtube Downloader Zone'});, .setButtonText('Copy Cookie'), containerEl.createEl('h2', { text: '💰 Support 支持 & Funding 赞助 💰'}); Use sentence case in UI and for section headings in settings use:
new Setting(containerEl).setName('name here').setHeading();
.setName('NoteLocationFolder'), .setName('DownloadFolder'), .setName('YoutubeSaveFolder') Use sentence case as above, and add some spaces. .setName('Blacklist') Stick to one language, the name is english while the description is chinese.
Fixed again, bro. Have a good day.
Halo, bro @joethei 👀 👀
Stop calling me bro.
And you haven't implemented all the things that have been requested.
Stop calling me bro.
And you haven't implemented all the things that have been requested.
Sorry to take up your time, joethei. Actually, I have addressed your issue place.
Please watch the new commit of the master branch. Example, section headings in settings use this way. And Sentence case like this, and this one language.
I may have misled you by not updating the code reference link in time. I used your issued code ref link, apologize again.
You missed this one:
background: url(https://s2.loli.net/2022/01/11/XyHnMBGWCl5Z9DK.png);, img3.src = 'https://github.com/ai-chen2050/obsidian-wechat-public-platform/raw/master/public/commutity.jpg';, img4.src = 'https://github.com/ai-chen2050/obsidian-wechat-public-platform/raw/master/public/wechat-motion-qr.png'; As part of our developer policies, it is not allowed to load remote resources for styling purposes, you need to encode these with base64, if you want them to be included.
Thanks for pointing out,please see new commit code here,
- img3.src = motivation;, and motivation havd been handle by base64 encode, please see here
- and img4.src = commutity;, is the same.
- Actually, the above two issues had been handled before.
- about this, background: url have been removed at this time.
Hi, @joethei, is there any other suggestions? Looks forward to seeing my plugin onboard at the Obsidian plugin marketplace. Thanks.