obsidian-releases
obsidian-releases copied to clipboard
Add plugin: ExcelViewer
I am submitting a new Community Plugin
Repo URL
Link to my plugin:
Release Checklist
- [ x ] I have tested the plugin on
- [ x ] Windows
- [ ] macOS
- [ ] Linux
- [ ] Android (if applicable)
- [ ] iOS (if applicable)
- [ x ] My GitHub release contains all required files
- [ x ]
main.js
- [ x ]
manifest.json
- [ x ]
styles.css
(optional)
- [ x ]
- [ x ] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix
v
) - [ x ] The
id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file. - [ x ] My README.md describes the plugin's purpose and provides clear usage instructions.
- [ x ] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
- [ x ] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
- [ x ] I have added a license in the LICENSE file.
- [ x ] My project respects and is compatible with the original license of any code from other plugins that I'm using.
I have given proper attribution to these other projects in my
README.md
.
Hello!
I found the following issues in your plugin submission
Errors:
:x: Your latest Release is missing the main.js
file.
:x: Your latest Release is missing the manifest.json
file.
Warnings:
:warning: Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.
This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.
trigger again
"description": "View and embed Excel files in the Obsidian.", Remove the "in the Obsidian" part, it should be self-evident that this is a plugin for Obsidian. We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple.
"fundingUrl": "https://github.com/Diselorya/Obsidian-ExcelViewer", This is meant for links to services like Buy me a coffee, GitHub sponsors and so on, if you don't have such a link omit this.
this.addRibbonIcon("table", "Create Excel File", async () => { Use sentence case in UI
name: "Create loom and embed it into current file", This name is wrong.
[1]:While there's no hard rule against it, we recommend against providing a default hotkey when possible. The reason being that it's easy to pick a hotkey that a user already has configured and they could get confused when that key doesn't do what they expect. Also, it's hard choosing a safe default hotkey that's available for all operating systems.
[1][2]:You should not cast this, instead use a instanceof
check.
[1][2][3]:Casting to any
should be avoided as much as possible.
[1]:Do not detach leaves with your custom view in onunload
, this is an antipattern, see: https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Don't+detach+leaves+in+%60onunload%60
[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30][31][32][33][34][35][36][37][38][39][40][41][42][43][44][45][46][47][48][49][50][51][52][53][54][55][56][57][58][59][60][61][62][63][64][65][66][67][68][69][70][71][72][73][74][75][76][77][78][79][80][81][82][83][84][85][86][87][88][89][90][91][92][93][94][95][96][97][98][99][100][101][102][103][104][105][106][107][108][109][110][111][112][113][114][115][116][117][118][119][120][121][122]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.
console.log("预览模式.constructor");, console.log("预览模式.onOpen");, console.log("预览模式.onClose"); and many more. Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.
import path from 'path';
This import is available from a Node.js runtime, which means that this will throw errors on Mobile (that's a problem since you have isDesktopOnly
marked as false
in your manifest.json file.
Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 30 days unless there are any updates.
Hi there, to keep things tidy, we're closing PRs after some inactivity. Feel free to create a new pull request when you're ready to continue.
Thanks for your understanding!