obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

Add T9R theme

Open nyxb opened this issue 1 year ago • 1 comments

I am submitting a new Community Theme

Repo URL

Link to my theme: https://github.com/The9Realms/obsidian-t9r

Theme checklist

  • [x] My repo contains all required files (please do not add them to this obsidian-releases repo).
    • [x] obsidian.css
    • [x] The screenshot file.
  • [x] I have indicated which modes (dark, light, or both) are compatible with my theme.
  • [x] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other themes that I'm using. I have given proper attribution to these other themes in my README.md.

nyxb avatar Sep 10 '22 22:09 nyxb

?

nyxb avatar Sep 15 '22 18:09 nyxb

Is this pull also processed?

nyxb avatar Oct 01 '22 19:10 nyxb

@VidarSec Sorry for the long review process, we've been busy with a big design overhaul in the recently released v1.0 of Obsidian. Now that 1.0 has been released and Obsidian's UI has undergone some sweeping changes, we are asking all theme entries to confirm that their theme is compatible with the latest version of Obsidian.

Let me know when you can confirm and I'll proceed to merge it! Awesome theme btw!

ericaxu avatar Oct 17 '22 19:10 ericaxu

Hi @VidarSec , sorry about the wait!

Have you tested your theme on 1.0? If it works please let me know so I can merge it!

One minor thing: you might want to make the screenshot smaller while keeping the 16:9 aspect ratio. That would make your theme load faster in the theme store. You can still include high resolution screenshots in your README.

We recommend using a screenshot of size 512px by 288px as the featured screenshot to minimize loading time.

ericaxu avatar Nov 09 '22 02:11 ericaxu

Hi @VidarSec do you still intent on submitting this theme?

joethei avatar Feb 24 '23 13:02 joethei

@joethei sure

nyxb avatar Feb 24 '23 13:02 nyxb

@joethei sure

Can you confirm the theme works well on Obsidian 1.0+?

If so we can merge it. Screenshot size reduction is also recommended!

ericaxu avatar Feb 24 '23 18:02 ericaxu

This theme currently does not have the new required structure. See here for our migration guide: https://forum.obsidian.md/t/1-0-theme-migration-guide/42537

joethei avatar Feb 24 '23 18:02 joethei