[Plugin] Obsidian Group Snippets

[Mara-Li]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/Mara-Li/obsidian-group-snippets

Release Checklist

• [x] I have tested the plugin on
  • [x] Windows
  • [ ] macOS
  • [ ] Linux
  • [ ] Android (if applicable)
  • [ ] iOS (if applicable)
• [x] My GitHub release contains all required files
  • [x] main.js
  • [x] manifest.json
  • [x] styles.css (optional)
• [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• [x] The id in my manifest.json matches the id in the community-plugins.json file.
• [x] My README.md describes the plugin's purpose and provides clear usage instructions.
• [x] I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
• [x] I have added a license in the LICENSE file.
• [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

[github-actions[bot]]

Hello Mara-Li!

I found the following errors in your plugin, Group Snippets:

:x: Unable to find a release with the tag "1.0.1". Make sure that the manifest.json file in your repo points to the correct Github Release

Log

HttpError: Not Found

---

^{This check was done automatically.}

[Mara-Li]

Okay, sorry for the failing validate plugin entry. I had (again) problem with my git. Normally, the manifest in the repo is the same of the manifest in the release.

[liamcain]

• const customCSS = (this.app as any).customCss; Instead of storing a reference to customCSS in your thunk, you should just move toggleEnabledSnippet into your plugin class. Then you can access this.app.customCss from within the function. Your implementation is dangerous if at any point, Obsidian has code to reinstantiate customCSS. Your reference would be stale.
• getAllSnippets Same here, this should just live on the modal class.
• groupSnippetNaming Style nitpick: classes should always be uppercase so that you can differentiate them from variable names.

[Mara-Li]

Change requested has been done in 1.5.0 (https://github.com/Mara-Li/obsidian-group-snippets/commit/cddf21851fe4bc0e6d0cf2abe65c4b583e621c04)