obsidian-releases icon indicating copy to clipboard operation
obsidian-releases copied to clipboard

version 1.0.1

Open shuise opened this issue 1 year ago • 4 comments

I am submitting a new Community Plugin

Repo URL

Link to my plugin:

Release Checklist

  • [x] I have tested the plugin on
    • [ ] Windows
    • [x] macOS
    • [ ] Linux
    • [ ] Android (if applicable)
    • [ ] iOS (if applicable)
  • [x] My GitHub release contains all required files
    • [x] main.js
    • [x] manifest.json
    • [ ] styles.css (optional)
  • [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • [x] The id in my manifest.json matches the id in the community-plugins.json file.
  • [x] My README.md describes the plugin's purpose and provides clear usage instructions.
  • [x] I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • [x] I have added a license in the LICENSE file.
  • [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

shuise avatar Aug 03 '22 02:08 shuise

Please fill out the form.

You should have clicked switched to preview and clicked on the "Community plugin" entry when creating this PR. I edited your message to include it.

joethei avatar Aug 11 '22 07:08 joethei

over

shuise avatar Aug 14 '22 10:08 shuise

I think you have a typo in your id and plugin name: pubilsh should be Publish probably

In your readme, please dont name it Obsidian Publish Plugin, that name is already reserved for the official Obsidian Publish offering https://obsidian.md/publish

import copy from 'clipboard-copy'; You don't need to import a library just for this one feature, the browser API's already provide navigator.clipboard.writeText()

this.addRibbonIcon("dice-glyph", "FlowUs", (event) => { I don't think that icons fits the plugin, you can use any of these icon names by default: https://lucide.dev/ I would also keep the plugin name consistent everywhere.

let api = 'https://notes.bluetech.top/api/download/history?t=1659140767096'; You probably don't want to have your token in the code, even if it's not used.

function html2md(htmlData){ Obsidian already provides a API for this: htmlToMarkdown(html: string) : string

You seem to be reading the rendered HTML, convert it to Markdown, just to put it into the clipboard. Obsidian notes are already stored in Markdown, so I don't see why this plugin would be necessary. Can you explain a bit more?

joethei avatar Aug 18 '22 11:08 joethei

I think you have a typo in your id and plugin name: pubilsh should be Publish probably

In your readme, please dont name it Obsidian Publish Plugin, that name is already reserved for the official Obsidian Publish offering https://obsidian.md/publish

import copy from 'clipboard-copy'; You don't need to import a library just for this one feature, the browser API's already provide navigator.clipboard.writeText()

this.addRibbonIcon("dice-glyph", "FlowUs", (event) => { I don't think that icons fits the plugin, you can use any of these icon names by default: https://lucide.dev/ I would also keep the plugin name consistent everywhere.

let api = 'https://notes.bluetech.top/api/download/history?t=1659140767096'; You probably don't want to have your token in the code, even if it's not used.

function html2md(htmlData){ Obsidian already provides a API for this: htmlToMarkdown(html: string) : string

You seem to be reading the rendered HTML, convert it to Markdown, just to put it into the clipboard. Obsidian notes are already stored in Markdown, so I don't see why this plugin would be necessary. Can you explain a bit more?

I just wanna to publish the render result to some content website(FlowUs is the first one), the result maybe composed by ![[]] or chart or other plugins, but content website doesnot support those components. So I had to render all markdown to html(text + table + image), convert to md again beacuse the FlowUs editor just allow paste md, and through clipboard pass the result into any browser from local obsidian editor.

Sorry, I donot konw those APIs, and I will fix the reviews, thanks.

shuise avatar Sep 09 '22 13:09 shuise

Hi sorry for the long delay, I didn't realize this was waiting on me to review.


liamcain avatar Nov 04 '22 19:11 liamcain

Hello shuise!

I found the following errors in your plugin, Work Publish to FlowUs:

:x: Plugin ID mismatch, the ID in this repo is not the same as the one in your repo.


This check was done automatically.

github-actions[bot] avatar Nov 04 '22 19:11 github-actions[bot]

Hi, @shuise before I merge this, would you like to fix the typo in your plugin ID? Once it's published, it's harder to change the plugin ID. I think you meant for it to be work-publish (instead of work-pubilsh).

liamcain avatar Nov 04 '22 20:11 liamcain

Hi @shuise do you still intent on submitting this plugin?

joethei avatar Feb 24 '23 13:02 joethei

Closing PR due to inactivity.

Feel free to reopen this PR if you still intend on submitting this plugin.

joethei avatar Mar 28 '23 09:03 joethei