obsidian-releases
obsidian-releases copied to clipboard
Add Gitlab Issues plugin
Add new community plugin, which can import issues from Gitlab into Obsidian.
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/benr77/obsidian-gitlab-issues
Release Checklist
- [x] I have tested the plugin on
- [x] Windows
- [x] macOS
- [x] Linux
- [x] Android (if applicable)
- [ ] iOS (if applicable)
- [x] My GitHub release contains all required files
- [x]
main.js
- [x]
manifest.json
- [ ]
styles.css
(optional)
- [x]
- [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix
v
) - [x] The
id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file. - [x] My README.md describes the plugin's purpose and provides clear usage instructions.
- [x] I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
- [x] I have added a license in the LICENSE file.
- [x] My project respects and is compatible with the original license of any code from other plugins that I'm using.
I have given proper attribution to these other projects in my
README.md
.
"author": "Ben Roberts [email protected]", Do you want your email address to be that public? It will be shown on https://obsidian.md/plugins and in the sidebar of the community plugins tab.
normalize
The Obsidian API provides normalizePath
for this.
fetch
The Obsidian API provides 'requestUrl' for this.
You can run into CORS issues with fetch
.
DataAdapter Try to not use that API if possible: https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md#prefer-the-vault-api-over-the-adapter-api
/.obsidian/
That path is not guaranteed, users can overwrite it in "Settings > About".
You can read that setting with app.vault.configDir
Hello @joethei. Thanks for your helpful pointers. I have now pushed the changes to the master branch of my plugin repository. Please can you review again.
Thanks
Hi! Sorry for such a long delay. This pull request got buried on the last page of our ever growing list of plugins and I didn't realize it was waiting on me to take a look 😶
Everything LGTM, just found a small nit but nothing to stop this from going in.
-
window.clearInterval(this.startupTimeout); I think you meant to use
window.clearTimeout
here. You have a timeout and not an interval.
Hi! Sorry for such a long delay. This pull request got buried on the last page of our ever growing list of plugins and I didn't realize it was waiting on me to take a look no_mouth
No problem - thanks for your efforts!
Everything LGTM, just found a small nit but nothing to stop this from going in.
- window.clearInterval(this.startupTimeout); I think you meant to use
window.clearTimeout
here. You have a timeout and not an interval.
This is now fixed in the latest release.