Added Conditional Random Note Plugin

[yizeshen7]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/yizeshen7/obsidian-conditional-random-note

Release Checklist

• [ ] I have tested the plugin on
  • [x] Windows
  • [x] macOS
  • [ ] Linux
  • [ ] Android (if applicable)
  • [ ] iOS (if applicable)
• [x] My GitHub release contains all required files
  • [x] main.js
  • [x] manifest.json
  • [ ] styles.css (optional)
• [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• [x] The id in my manifest.json matches the id in the community-plugins.json file.
• [x] My README.md describes the plugin's purpose and provides clear usage instructions.
• [x] I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
• [x] I have added a license in the LICENSE file.
• [x] My project respects and is compatible with the original license of any code from other plugins that I'm using. I have given proper attribution to these other projects in my README.md.

[joethei]

"Sample Plugin" I don't think that this is the correct name.

file.stat.ctime Depending on the operating system this might be 0, just something to keep in mind.

ribbonIconEl.addClass("my-plugin-ribbon-class"); Remove this if you are not using any CSS.

if (typeof Number(value) == "number") { You should notify the user in case they input a invalid value. You also only need to save if its valid.

[yizeshen7]

Hi joethei!

Went through your comments and made some changes, would love to have you take another look, thanks :D

[yizeshen7]

Hm accidentally deleted my plugin entry it seems like, @joethei @liamcain wonder if there is a way I can roll back?

[liamcain]

@yizeshen7 The easiest way is probably run git fetch origin && git reset --hard origin/master on your fork of obsidianmd/obsidian-releases and just add the plugin to the end of the list.

[yizeshen7]

@liamcain Perfect thanks Liam! Was able to update, let me know if there is anything else you all need :).

[liamcain]

Hi @yizeshen7, have you tried contributing to the Smart Random Note plugin at all? https://github.com/erichalldev/obsidian-smart-random-note. Seems like your plugin has similar goals with slightly different features.

---

Otherwise, here's just some comments on the code itself:

• word.path.includes(this.settings.destinationFolder) Instead of includes, this should probably be startsWith to avoid bugs
• const FolderFiles = files.filter((word) => Style nit: I recommend lowercasing keeping variables lowercase and only using uppercase/pascalcase for class names.
• // When registering intervals, this function will automatically clear the interval when the plugin is disabled. You can remove this

[ericaxu]

@yizeshen7 Hi! Do you still intend to submit this plugin? Thanks!

[joethei]

Closing PR due to inactivity.

Feel free to reopen this PR if you still intend on submitting this plugin.