kafdrop
kafdrop copied to clipboard
obsidiandynamics
Add github actions to publish helm chart
I have setup a github actions to publish Kafdrop helm chart. It uses local github pages in order to publish Charts.
In order to set this up, you will have to push a new branch gh-pages to the main repository and configure Github pages in your repository settings.
After merging to master, a new Chart will be updated every time master branch is updated.
After the Actions step is complete, the chart is available in your github pages configured URL -
Known issue:
- Because the branch gh-pages has to be kept updated with master in order to publish changes, the rebase step uses
oursas the strategy to give priority to master changes in case of a conflict. Due to this, only 1 chart version can remain in the chart directory.
Closes #98
Would be very nice to have kafdrop helm charts repo ! The integration as a dependency inside a bigger umbrella charts is painful, it would fit naturally with a helm dependency.
@vietk I am not sure I follow.. Do you mean that the helm charts should be hosted on a public repo like Chartmuseum instead of gh-pages?
As long as is it possible to use the chart with :
helm repo add
and install it as a dependency of another chart, I think it's ok
Does this allow a user to download an arbitrary chart version (based on a release tag)?
@ekoutanov as mentioned in the message in the PR, it supports only latest version at the moment. If you are okay with having github pages as your helm chart repository, I can make a fix to support arbitrary chart versions as well..
I would like to see this as well. I am going to make a proposal PR for a new chart version (which fixes some bugs and is helm v3 compatible). But wouldnt it be an option to integrate to charts to the google helm repository (incubtor and then stable: https://github.com/helm/charts/tree/master/incubator)? I dont see any dependency within this chart and it would also reduce the complexity of this chart. On the other Hand your chart is in another repository. WAre there any thoughts on that?
This feature would be a great addition to Kafdrop. The issue is that there are many ways to make this happen (the PR raised here is one of them)
I am happy to jump on a call with any of the maintainers in order to understand the requirement and then I can make the changes to this PR accordingly.
@shantanualsi Thanks for your efforts. As soon as this is solved I can create a PR for a v3 rewrite of the chart. I am currently building a public helm repo for our company. I can offer, that we could move the chart over there. We have a few people which have good know-how in helm charts. This way it would be possible to have faster reviews and merges within the chart. Lemme know when you know more
At this stage I would rather not use gh pages for this; we may want to use it for other things. I suggest that anyone who needs a hosted helm repo should just host it locally for the time being.
To anyone still interested: We published an unofficial Kafdrop Chart: https://artifacthub.io/packages/helm/main/kafdrop Please feel free to test it and contribute :)
@ekoutanov can you explain exactly why you don't want to host an official chart repo? If not in github pages then somewhere else? Seems like it would take very little effort to stand that up and even maintain it manually for a while. Seems also that you have several people here willing to help and contribute. For those of us who want to use kafdrop as a dependency in our own charts, doing that would make life So. Much. Simpler. I just don't understand the resistance to the idea.
Pinging again after over a year of no action here. Is there any reason not to provide a hosted chart, even under a temporary setup?
