obsidian-tasks icon indicating copy to clipboard operation
obsidian-tasks copied to clipboard

feat: add feature class and framework

Open sytone opened this issue 2 years ago • 1 comments

Description

Adds in the feature framework so it can be used to manage new features for user testing but not impact all users by default by having a new feature on by default.

Motivation and Context

New changes have a higher chance of impact until initial issues are resolved, being able to deploy with them off by default allows changes to get out faster to users to test and use.

How has this been tested?

Used heavily in fork with no issues and added basic unit tests.

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Refactor (non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x] My code follows the code style of this project and passes yarn run lint.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] My change has adequate Unit Test coverage.

By creating a Pull Request you agree to our Code of Conduct. For further guidance on contributing please see contributing guide

sytone avatar Aug 02 '22 22:08 sytone

Hey, @sytone

I was thinking about this over night... If you haven't started the renaming of symbols - and the suggested/requested renames would cause a problem for you in tasks-x - then feel free to instead just improve the docs for the various comments - to clearly state their purpose and use - so that at least anyone hovering over the symbols in a good IDE will immediately know what they do.

claremacrae avatar Aug 04 '22 21:08 claremacrae

When I make changes to variables and parameters on this side I backport to my repo so they stay in sync, renames are not usually a issue. Search and replace is your friend.

Been away for a while and will hopefully get time on the weekend to catch up.

sytone avatar Aug 19 '22 17:08 sytone

When I make changes to variables and parameters on this side I backport to my repo so they stay in sync, renames are not usually a issue.

Thanks.

Search and replace is your friend.

Erm. I can't tell if you're joking! 😀

Maybe 95% of the time, the rest of the time it's a great way to introduce bugs!

I would always recommend using an IDE that has proper rename refactoring.

Been away for a while and will hopefully get time on the weekend to catch up.

Awesome. Many thanks.

claremacrae avatar Aug 19 '22 17:08 claremacrae

@sytone Because of the upcoming reformatting and restructuring of code in this repo, I've gone ahead and merged this.

Please do go ahead and address the outstanding code-review issues here, though - in a new PR after the rearranging...

claremacrae avatar Sep 05 '22 13:09 claremacrae