obsidian-tasks icon indicating copy to clipboard operation
obsidian-tasks copied to clipboard

Remove warning about Reminders not working for recurring tasks, as the Reminders issue was resolved

Open adamfeldman opened this issue 11 months ago • 3 comments

Description

Docs update. The reason this warning was documented was this: https://github.com/uphy/obsidian-reminder/issues/93

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • [ ] Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • [ ] New feature (prefix: feat - non-breaking change which adds functionality)
  • [ ] Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
  • [x] Documentation (prefix: docs - improvements to any documentation content for users)
  • [ ] Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)
  • [ ] Contributing Guidelines (prefix: contrib - any improvements to documentation content for contributors - see Contributing to Tasks)

Internal changes:

  • [ ] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • [ ] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
  • [ ] Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

  • [ ] My code follows the code style of this project and passes yarn run lint.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] My change has adequate Unit Test coverage.

Terms

adamfeldman avatar Mar 05 '24 14:03 adamfeldman

Hi, thank you for the contribution.

I wonder whether you missed these checkboxes in the template accidentally:

image

This same change was offered in an earlier pull request - #2514 - in which I explained why just removing the warning was not sufficient.

If you would like to read the notes on that one, and address the concerns there, it would be greatly appreciated.

claremacrae avatar Mar 05 '24 14:03 claremacrae

HI @claremacrae, thanks for the pointer to #2514. I will take a look.

adamfeldman avatar Mar 05 '24 14:03 adamfeldman

HI @claremacrae, thanks for the pointer to #2514. I will take a look.

Thanks Adam - and thanks too for updating the checklists.

claremacrae avatar Mar 05 '24 14:03 claremacrae