obsidian-full-calendar icon indicating copy to clipboard operation
obsidian-full-calendar copied to clipboard

Possible fix for issue #311

Open fcortell opened this issue 1 year ago • 2 comments

Added ical-expander to help calendar get more info about timezones.

fcortell avatar Dec 14 '23 11:12 fcortell

Requested changes commited.

fcortell avatar Dec 18 '23 05:12 fcortell

Thank you @fcortell! Would you be able to add some unit tests to confirm that timezones are working as expected? Some tests that would be useful given issues that users have had in the past:

  • Event in GMT, user in a non-UTC timezone (e.g. Americas/New_York)
  • Instance of a Rrecurring event scheduled before daylight savings, after daylight savings
  • Event in Americas/New_York, user in a UTC timezone or a UTC+1 timezone
  • Event/user in Indian Standard Time (UTC+5:30)

These could be snapshot-based tests that live in src/calendars/parsing/ics.test.ts.

davish avatar Dec 20 '23 03:12 davish