Josiah Bills

I am doing some more research. It looks like the dirty flag is being cleared before calling the save handler. Call stack for the dirty flag clear: ``` Elders.VSE_FormatDocumentOnSave.dll!Elders.VSE_FormatDocumentOnSave.FormatDocumentOnBeforeSave.OnAfterAttributeChangeEx(uint docCookie,...

I went ahead and put in a feedback item for this: https://developercommunity.visualstudio.com/t/Visual-Studio-clears-dirty-flag-before-c/10124978. I have had trouble getting feedback through Microsoft's triage before, so I would appreciate it if @mynkow you...

`FormatDocumentOnBeforeSave::OnAfterAttributeChangeEx` is the callback where it happens. If the flag variable is `16` then the file is having its dirty flag cleared. A quick test reveals that this is happening...

[test.zip](https://github.com/Elders/VSE-FormatDocumentOnSave/files/9396144/test.zip) Minimal cmake project which I can repro the issue with. To enable clang format support, `Options->Text Editor->C/C++->Code Style->Formatting->General->Enable ClangFormat support`. That said, I tried disabling Clang-Format and still have...

Is there an upstream issue on VSCode to allow this to be fixed? Can this be worked around temporarily by hiding docs whenever an error would also be displayed?

Looking into this I don't think that would work. The score algorithm is based on the strength of the file's match. Rust-Analyzer should get 10, the max, on every `.rs`...

Just a comment on a usecase for this, I would like to wrap `plotters` in a matlab/matplotlib style api using `plotters-iced` as a backend. For this to work I would...

So, a decent chunk of this code is just plumbing that would be needed for #58. In fact, I could do up a follow up that implements that issue using...

One question: is `IMPORTED_CRATES` intended to yield a list of targets instead of crates? If so, would it be reasonable to add a new `IMPORTED_TARGETS` input and deprecate `IMPORTED_CRATES`?

> [string(MAKE_C_IDENTIFIER)](https://cmake.org/cmake/help/latest/command/string.html#make-c-identifier) Just to be clear, do you want me to replace my existing `string(REPLACE)` with this?