plot icon indicating copy to clipboard operation
plot copied to clipboard

ts api

Open Fil opened this issue 3 years ago • 1 comments

rebooting #1001 with a "typescript as documentation" approach.

Things to watch for:

  • [ ] Plot.valueof(undefined, () => {}) crashed
  • [ ] Plot.map("foo") crashed
  • [x] Plot.selectMinX potentially inserted undefined in the facet index
  • [x] mid(x1, x2) was wrongly typed (it expected a data argument)
  • [x] the API for marker passed a Context as {document}, now just passes document: see e891948
  • [x] Plot.stackY crashes on some orders: ("z", "appearance", etc) and X or Y are missing
  • [x] The window transform used the percentile function with the wrong types

Fil avatar Jul 23 '22 21:07 Fil

This PR would be monstruous to review. I'm leaving it as a draft to show the context, but I'll submit it separately in digestible pieces. The first piece will be data.ts + options.ts

Fil avatar Jul 26 '22 15:07 Fil

Probably superseded by #1320 which goes the d.ts route. Close?

mbostock avatar Mar 13 '23 17:03 mbostock