obo-relations icon indicating copy to clipboard operation
obo-relations copied to clipboard

Add regulates to relations which propagate 'in taxon'.

Open balhoff opened this issue 1 year ago • 3 comments

The historical usage of 'regulates' assumes it is within a single organism. For this reason we have the term regulates in another organism without that assumption. This PR adds 'regulates' to the relations which propagate 'in taxon'.

This is good for GO, but does seem to assume a biological context. I'm not sure if the definition of 'regulates' should be tweaked to make that context more clear.

See also https://github.com/geneontology/go-ontology/issues/29010

balhoff avatar Oct 18 '24 16:10 balhoff

We need to make sure this won't break existing ontologies or their downstream ontologies.

All regulates axioms are likely in GO - if GO passes with this then we should be good to GO. If GO axioms need changed then we need time for releases to percolate, otherwise mixing certain versions of RO and GO will introduce incoherencies.

cmungall avatar Oct 18 '24 17:10 cmungall

@cmungall

Can we give some review period for concerned groups to evalute the impact on their ontologies?

Otherwise we should look for an alternative strategy to propagate these TCs in GO.

pgaudet avatar Oct 21 '24 11:10 pgaudet

I can try adding this to a test Ubergraph build to see if there are negative consequences.

balhoff avatar Oct 28 '24 14:10 balhoff

Nov 4, 2024. Jim will do the test soon.

ddooley avatar Nov 04 '24 16:11 ddooley

I checked this group of merged ontologies with this property chain, and didn't find any unsatisfiabilities: https://github.com/INCATools/ubergraph/blob/master/ci/test-merged.ofn

balhoff avatar Nov 06 '24 01:11 balhoff