obo-relations icon indicating copy to clipboard operation
obo-relations copied to clipboard

rename "exposure event or process" to "exposure of organism" (issue 599)

Open wdduncan opened this issue 3 years ago • 2 comments
trafficstars

  • add exposure event class
  • change domain of 'related via exposure to' to 'exposure event'
  • obsolete 'exposure event or process'

wdduncan avatar May 02 '22 22:05 wdduncan

Fixes #599

@matentzn @diatomsRcool @laurenechan @cmungall The goal of this PR is to fix the confusion created by having both exposure event and exposure event or process classes in ECTO.

It also relates to COB issue https://github.com/OBOFoundry/COB/issues/192.
If COB mints a new IRI for exposure event, we may need to obsolete this class.

wdduncan avatar May 02 '22 22:05 wdduncan

COB has added the class exposure of organism (PR).
The class has not been added to a COB release (i.e., it is only in cob-edit.owl). I've submitted an issue concerning when COB will create a release.

wdduncan avatar Aug 18 '22 17:08 wdduncan

@cmungall This is being held up b/c we are waiting on new release of COB. Are you the only one who release COB? Can you assign some else?

wdduncan avatar Nov 01 '22 16:11 wdduncan

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

github-actions[bot] avatar Jan 31 '23 02:01 github-actions[bot]

Update: The COB class needed is ready. I just need to find the time to circle back to this.

wdduncan avatar Jan 31 '23 02:01 wdduncan

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

github-actions[bot] avatar May 02 '23 02:05 github-actions[bot]

@anitacaron I've been holding of on this until the COB is ready so that I can use the COB class.

wdduncan avatar Jun 12 '23 14:06 wdduncan

@wdduncan, Do you need help fixing the conflicts in the ro-edit.owl?

anitacaron avatar Jun 12 '23 14:06 anitacaron

@anitacaron I don't think there will be any conflicts (I hope).
Now that exposure of organism is in COB, I think I just need to change the IRI for exposure event or process (and label) to match the COB class (which currently not in RO).

wdduncan avatar Jun 12 '23 14:06 wdduncan

There's already a conflict in this branch, but I'll wait for you to add the COB term. Do you need help importing COB?

anitacaron avatar Jun 12 '23 14:06 anitacaron

Just an update:
Waiting on #717 to complete before continuing on this. That PR has a COB import file that I will used to add the necessary class.

wdduncan avatar Jul 17 '23 14:07 wdduncan

COB is already ready to use. It was merged in PR #736. I can fix the conflict in the edit file.

anitacaron avatar Jul 17 '23 14:07 anitacaron

COB is already ready to use. It was merged in PR https://github.com/oborel/obo-relations/pull/736. I can fix the conflict in the edit file.

@anitacaron Your help would be greatly appreciated! :)

wdduncan avatar Jul 17 '23 14:07 wdduncan

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

github-actions[bot] avatar Oct 16 '23 01:10 github-actions[bot]

This has been open for quite a while. I need to review to see what needs to be done in order to finish.

wdduncan avatar Oct 16 '23 13:10 wdduncan

Still working on this.

wdduncan avatar Oct 22 '23 02:10 wdduncan

We recommend the ECTO group mint an ID for exposure event for now, with the understanding it may be deprecated and replaced by a COB class eventually

We will then replace the usage of the current RO class in domains and ranges with the ECTO URI (and later with the COB URI)

@anitacaron @cmungall The IRI has been changed to COB_0001000 (from COB). Can we move forward now.

wdduncan avatar Nov 06 '23 12:11 wdduncan

This PR has not seen any activity in 90 days and has been marked as stale. If it is no longer needed, please close the PR. Otherwise, please update the PR with a status update.

github-actions[bot] avatar Feb 06 '24 01:02 github-actions[bot]