uberon icon indicating copy to clipboard operation
uberon copied to clipboard

update HBA bridge mappings to nerves to point to nerve roots

Open dosumis opened this issue 1 year ago • 10 comments

CC @gouttegd - Can you confirm how we should update Allen Brain Atlas bridge files now. (I should probably know this!)

  • We may also need to check whether all ABA terms are being classified as brain region.

dosumis avatar Apr 26 '24 13:04 dosumis

All bridge files (including the custom ones like the MBA and DMBA bridges) are updated with a single command:

sh run.sh make refresh-bridges

This is normally done by @anitacaron (as part of the refresh of all external resources) ahead of a release, but can be done anytime by anyone if there’s a need.

gouttegd avatar Apr 26 '24 15:04 gouttegd

Wait, do you mean updating the contents of the bridges?

It depends on the bridge. For the MBA and DMBA bridges, they are entirely managed outside of Uberon, so they should be updated in their respective repositories (https://github.com/brain-bican/mouse_brain_atlas_ontology and https://github.com/brain-bican/developing_mouse_brain_atlas_ontology).

For the HBA, DHBA, and PBA bridges, the source of truth is still the Uberon -edit file, more precisely the cross-references carried by Uberon term.

gouttegd avatar Apr 26 '24 15:04 gouttegd

So for example, Uberon’s hypoglossal nerve (UBERON:0001650) is currently mapped to HBA:9343. To remap the HBA term to Uberon’s hypoglossal nerve root (UBERON:0004675), you need to remove the HBA:9343 cross-reference on UBERON:0001650 and put it on UBERON:0004675 instead.

gouttegd avatar Apr 26 '24 15:04 gouttegd

@AvolaAmg - can you make these edits to Uberon? Would be good to do soon if poss and work with @aleixpuigb to make an Uberon release as this affects our ability to do PCL updates. @hkir-dev - can you provide a list of nerve terms in HBA?

dosumis avatar Apr 27 '24 10:04 dosumis

Nerves
https://purl.brain-bican.org/ontology/hbao/HBA_9337
https://purl.brain-bican.org/ontology/hbao/HBA_9328
https://purl.brain-bican.org/ontology/hbao/HBA_9319
https://purl.brain-bican.org/ontology/hbao/HBA_9325
https://purl.brain-bican.org/ontology/hbao/HBA_9300
https://purl.brain-bican.org/ontology/hbao/HBA_9322
https://purl.brain-bican.org/ontology/hbao/HBA_9343
https://purl.brain-bican.org/ontology/hbao/HBA_9334
https://purl.brain-bican.org/ontology/hbao/HBA_9316
https://purl.brain-bican.org/ontology/hbao/HBA_9331
https://purl.brain-bican.org/ontology/hbao/HBA_9340
https://purl.brain-bican.org/ontology/hbao/HBA_9299

Explanation of unsats: unsats.md

@AvolaAmg you can run make command in this folder (hba_test.zip) to reproduce the issue. Then you can locally edit the bridge file and see if unsats are fixed. Please slack me for any issue.

hkir-dev avatar Apr 28 '24 19:04 hkir-dev

Can you summarize some commonalities between these? I expect there is a common cause. (I have found simply feeding unsats.md into long-context model AIs like claude to be a fast way of getting at underlying causes)

Message ID: @.***>

cmungall avatar Apr 29 '24 15:04 cmungall

This axiom in HBA seems very wrong (or at the very incompatible with Uberon):

cranial nerves SubClassOf part_of some myelencephalic white matter

HBA’s cranial nerves is mapped to the equivalent term in Uberon (UBERON:0001785), which is classified as being part of the peripheral nervous system. And HBA’s myelencephalic whit matter is mapped to Uberon’s white matter of myelencephalon (UBERON:0019262), which (through hindbrain and white matter) is ultimately part of the central nervous system.

gouttegd avatar Apr 29 '24 15:04 gouttegd

I think you have to read these from the perspective of how the annotated domains relate to each other on a 3D brain. I'll try to pull out an image to post.

dosumis avatar Apr 29 '24 19:04 dosumis

@AvolaAmg - can you make these edits to Uberon? Would be good to do soon if poss and work with @aleixpuigb to make an Uberon release as this affects our ability to do PCL updates.

@anitacaron is planning to do an Uberon release soon (probably this week). @AvolaAmg, do you need help with this ticket to make sure it gets in this release?

aleixpuigb avatar May 07 '24 15:05 aleixpuigb

Hi @aleixpuigb thanks for your offer, I will have a look at this ticket tomorrow first thing and let you know if I need any help.

AvolaAmg avatar May 07 '24 15:05 AvolaAmg