obophenotype
Remove `part_of o develops_from -> develops_from` injection
The “gogoeditdiff“ action failed to post the diff because it is too large (comments are apparently limited to 64 KB). Here’s the diff: simple-report.md
The few changes I’ve looked at seem exactly the kind of changes we’d expect upon removal of the chain.
this shouldn't happen:
upper jaw region http://purl.obolibrary.org/obo/UBERON_0001709
Removed
add property chain 'has part' o 'has developmental contribution from' -> 'has developmental contribution from' (edit existing which I think uses 'develops from')
This property chain is in RO, so the change needs to be done there. I'll create an issue there.
@anitacaron I presume you intend to take care of the second action item (“remove "derived" probe classes (e.g. "ectoderm-derived structure", and other germ layers)”) in a separate PR?
If so, looks good to me here, given that the other item needs to happen elsewhere.
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Discussing this on a call. We are unsure why this property chain is being removed (apart from that it ultimately should come from RO. It is doing useful work for inference that we likely can't effectively manage by hand. ALso note - we seem to have effectively the same axiomatisation via the subproperty of develops_from: develops_from_part_of https://www.ebi.ac.uk/ols4/ontologies/clo/properties/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FRO_0002225 - shouldn't this suffice to give the inference we need, and if it currently does not, why not?
(Note - the other property chain 'develops_from o part_of --> develops_from should be removed - has_developmental_contribution_from is sufficient).
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.
In the last RO call it was decided to test the various combinations of actions regarding the injected chains (remove both, remove one, remove the other) and have a look at the corresponding diffs to better understand the consequences of each chain and of their removal.