uberon icon indicating copy to clipboard operation
uberon copied to clipboard

multicellular organism disjoint from organism substance #2421

Open ddooley opened this issue 2 years ago • 8 comments

Addresses Issue #2421 . This is in external disjoints file though the two terms are native to Uberon though.

ddooley avatar Dec 14 '23 04:12 ddooley

GitHub action is having issues posting the comment because it comes from a fork, but there're unsats in this PR.

This PR violates some taxon constraints. Here is what the reasoner has to say:

Barley yellow dwarf virus SubClassOf Nothing

Luteovirus pavhordei SubClassOf Nothing

Barley yellow dwarf virus (ISOLATE MAV-PS1) SubClassOf Nothing

Histoplasma capsulatum var. duboisii H88 SubClassOf Nothing

median vaginal canal SubClassOf Nothing

lateral vaginal canal SubClassOf Nothing

Barley yellow dwarf virus (ISOLATE P-PAV) SubClassOf Nothing

Barley yellow dwarf virus MAV SubClassOf Nothing

Luteovirus mavhordei SubClassOf Nothing

Bean leafroll virus SubClassOf Nothing

Luteovirus phaseoli SubClassOf Nothing

Barley yellow dwarf virus (ISOLATE NY-RPV) SubClassOf Nothing

Barley yellow dwarf virus PAV SubClassOf Nothing

Luteovirus SubClassOf Nothing

unclassified Luteovirus SubClassOf Nothing

Axiom Impact

Axioms used 12 times

Axioms used 3 times

Axioms used 2 times

Axioms used 1 times

Ontologies used:

  • core.owl (http://purl.obolibrary.org/obo/uberon/core.owl)

anitacaron avatar Dec 15 '23 10:12 anitacaron

The obvious problem in Uberon is here:

With “channel for” being range-restricted to “organism substances”, it is obviously a mistake to say the vaginal canal is a “channel for” the embryo. Either the range restriction on that relation should be relaxed if the intention is for it to be used for more than just substances, or the relationship between “median vaginal canal” and “embryo” should either be dropped or replaced by a more suitable relation.

gouttegd avatar Dec 15 '23 13:12 gouttegd

But I am puzzled by the other unsats, which don’t seem to have anything to do with Uberon at all.

gouttegd avatar Dec 15 '23 13:12 gouttegd

I can’t reproduce the other unsats locally. The only unsats I get running the test suite locally are the ones caused by median vaginal canal as explained above.

gouttegd avatar Dec 15 '23 15:12 gouttegd

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

github-actions[bot] avatar Feb 02 '24 01:02 github-actions[bot]

The NCBITaxon unsats likely due to superimposition of 2 versions of NCBITaxon (this is one of the key motivations for base files). Difference between local and actions may be due to difference in versions on the network and/or triggering rebuilds of mirrors (but I defer to the Damien with an E who knows ODK better than me)

As for channeling embryos, rococo/vanity axiom, remove it

cmungall avatar Feb 02 '24 03:02 cmungall

@ddooley Can you remove the “median vaginal canal SubClassOf channel for some embryo“ axiom in Uberon? It makes sense that this should be done as part of this PR, since the incorrectness of this axiom was revealed by the addition of your disjointness axiom between “multicellular organism“ and “organic substance“.

I would also suggest that said disjointness axiom should be added to the main Uberon source file (uberon-edit.obo) rather than the external-disjoints.obo component. That component is only merged at build time, so its axioms are not visible to editors at edit time (e.g. in Protégé). This creates a risk than an editor could later violate the disjointness with no way of realising it until they submit a PR and the violation is caught by the test suite.

gouttegd avatar Feb 02 '24 09:02 gouttegd

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

github-actions[bot] avatar May 09 '24 01:05 github-actions[bot]