uberon icon indicating copy to clipboard operation
uberon copied to clipboard

adding cheek teeth

Open meghalithic opened this issue 2 years ago • 5 comments

issue #2585

meghalithic avatar Aug 10 '22 20:08 meghalithic

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-31/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-31/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

UBERON_7500108 http://purl.obolibrary.org/obo/UBERON_7500108

Added

github-actions[bot] avatar Aug 10 '22 22:08 github-actions[bot]

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

UBERON_7500108 http://purl.obolibrary.org/obo/UBERON_7500108

Added

github-actions[bot] avatar Aug 10 '22 22:08 github-actions[bot]

@bvarner-ebi by singular form do you mean cheek tooth?

meghalithic avatar Aug 11 '22 21:08 meghalithic

@bvarner-ebi by singular form do you mean cheek tooth?

Hi @megbalk, yes. Conventionally singular forms are used in labels and definitions.

ghost avatar Aug 12 '22 08:08 ghost

I may need to add cheektooth row, under "tooth row" to refer to the set of cheek teeth. Should I make a new issue for that or add it to the current one?

meghalithic avatar Aug 15 '22 19:08 meghalithic

I may need to add cheektooth row, under "tooth row" to refer to the set of cheek teeth. Should I make a new issue for that or add it to the current one?

At this stage it may be easier to finalise this issue and extend the additional work in a separate issue that references the current issue.

ghost avatar Aug 18 '22 15:08 ghost

Great, I can do that. I made it singular. Was that the only change?

meghalithic avatar Aug 18 '22 15:08 meghalithic

Great, I can do that. I made it singular. Was that the only change?

I think @cmungall is suggesting to use the synonym type plural, similar to how it is used for UBERON:0004346 'gubernaculum (male or female)', as an example.

Screenshot 2022-08-19 at 09 37 39

I'm not familiar with the use cases for the property type 'plural term', which may be OK, but I do not see that used elsewhere in the ontology.

ghost avatar Aug 19 '22 08:08 ghost