uberon icon indicating copy to clipboard operation
uberon copied to clipboard

adding hormion

Open meghalithic opened this issue 3 years ago • 11 comments

issue #2573

meghalithic avatar Jul 20 '22 15:07 meghalithic

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-09-30/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-09-30/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

UBERON_7500106 http://purl.obolibrary.org/obo/UBERON_7500106

Added

github-actions[bot] avatar Jul 20 '22 17:07 github-actions[bot]

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

UBERON_7500106 http://purl.obolibrary.org/obo/UBERON_7500106

Added

github-actions[bot] avatar Jul 20 '22 17:07 github-actions[bot]

Error is from term being unsat. Running:

% robot --catalog catalog-v001.xml merge -i tmp/uberon-edit.owl -I http://purl.obolibrary.org/obo/bfo.owl -I http://purl.obolibrary.org/obo/ro.owl -i bridge/uberon-bridge-to-bfo.owl --output test.owl 
shawntan@C02DW26DML87 /Users/shawntan/documents/GitHub/uberon/src/ontology [issue-2573]
% robot explain -i test.owl -M unsatisfiability --unsatisfiable random:10 --explanation unsat.md

Output:

hormion SubClassOf Nothing

Axiom Impact

Axioms used 1 times

Ontologies used:

  • core.owl (http://purl.obolibrary.org/obo/uberon/core.owl)

shawntanzk avatar Aug 26 '22 15:08 shawntanzk

@shawntanzk I do not get that same error when I run the reasoner (ELK).

Jugal point (UBERON:0013423) is classified the same way.

meghalithic avatar Aug 26 '22 15:08 meghalithic

The unsat is not from uberon-edit itself but a product that is used for the report tha the QC uses to check something. Seems to merge uberon-edit with bfo, ro, and bfo bridge. Not sure about the other term, will check again next week, but probably still need to fix the unsat

shawntanzk avatar Aug 26 '22 20:08 shawntanzk

@megbalk

I think this is your offending axiom: UBERON_7500106 SubClassOf zone of bone organ

From my understand of your PR, hormion is a point which is immaterial. However zone of bone organ is a material thing - it refers to an actual bone structure itself.

I assume this axiom would cause issue too:

UBERON_7500106 SubClassOf mesoderm-derived structure

Perhaps consider using 'part of' instead of subclass

shawntanzk avatar Aug 27 '22 07:08 shawntanzk

fixed!

meghalithic avatar Aug 30 '22 20:08 meghalithic

@shawntanzk do my changes look ok?

meghalithic avatar Sep 14 '22 17:09 meghalithic

QC checks have passed, I'll leave @bvarner-ebi to review content :) thanks

shawntanzk avatar Sep 14 '22 17:09 shawntanzk

@shawntanzk @bvarner-ebi could one of you review this, please?

meghalithic avatar Oct 13 '22 22:10 meghalithic

@bvarner-ebi - hope its ok if I leave you to do the final review for this. Thanks

shawntanzk avatar Oct 14 '22 08:10 shawntanzk

@bvarner-ebi here is a link to the dbxref: https://www.biblio.com/9780873659505. Let me know if I need to change how I'm reporting as this has been an issue before

I don't mind the definition provided by https://locatelambda.org/manual, but I do want to note that it is on the suture.

meghalithic avatar Oct 19 '22 21:10 meghalithic