uberon icon indicating copy to clipboard operation
uberon copied to clipboard

Make Neck more generalizable

Open shawntanzk opened this issue 3 years ago • 4 comments

Currently Fish cannot have a neck because of taxon constraints

@cmungall commented (https://github.com/obophenotype/uberon/issues/2367#issuecomment-1096815312): "I think the best solution would be to generalize neck in a way that keeps the fish people happy. Fish may lack a neck proper but they have an analogous region of the craniocervucal region with the same skeletal elements"

For now, we are making a taxon GCI (https://github.com/obophenotype/uberon/pull/2415) but a better solution is to make neck more generalizable like the above

I'm assigning myself for now so that it doesn't got unassigned, but I would like someone who is more knowledgeable about fish stuff to take over this ticket (not sure who, but if anyone knows, please do assign them/let me know)

shawntanzk avatar Apr 14 '22 08:04 shawntanzk

Cc @wdahdul

cmungall avatar Apr 19 '22 13:04 cmungall

Thanks for copying me (and apologies for the delay!). The terms ‘neck’ or ‘craniocervical’ or ‘cervical’ aren’t used in the fish comparative literature for the region behind the skull, and as far as I know, there is no generalized term for that region in fish anatomy. For example, the vertebrae directly behind the head in fishes are called ‘precaudal vertebrae’ meaning that they are anterior to the caudal vertebrae.

@megbalk and I reviewed the related ticket and if the best option is a taxonomic constraint, we suggest using this: 'jugular vein' and ('in taxon' some Sarcopterygii) SubClassOf 'part of' some neck. In the related ticket, this was expressed at the level of Mammalia, but it can be broadened to Sarcopterygii (lobe finned fishes)– see the curator note on ‘neck’:

"true necks are considered to be present when the pectoral girdle is separate from the skull - Tiktaalik is the earliest known fish to have a true neck."

wdahdul avatar Jun 28 '22 20:06 wdahdul

unfortunately tooling support for taxon GCIs are not great. This means people coming to OLS etc with mammals in mind looking under neck would not see jugular vein.

cmungall avatar Jul 06 '22 19:07 cmungall

@cmungall - could you suggest and actionable item for this please? thanks :)

shawntanzk avatar Aug 22 '22 17:08 shawntanzk

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

github-actions[bot] avatar Feb 19 '23 02:02 github-actions[bot]

generalize the existing taxon GCI from mammals to Sarcopterygii

On Mon, Aug 22, 2022 at 10:23 AM Shawn Tan @.***> wrote:

@cmungall https://github.com/cmungall - could you suggest and actionable item for this please? thanks :)

— Reply to this email directly, view it on GitHub https://github.com/obophenotype/uberon/issues/2417#issuecomment-1222667380, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOIMBF7OA4HWP3V5N43V2OZQNANCNFSM5TNCSE2A . You are receiving this because you were mentioned.Message ID: @.***>

cmungall avatar Feb 20 '23 16:02 cmungall

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

github-actions[bot] avatar Aug 27 '23 01:08 github-actions[bot]

@aleixpuigb, can you try to work on this issue because we have a straightforward fix for it, please?

cmungall: generalize the existing taxon GCI from mammals to Sarcopterygii

change the taxon GCI here to Sarcopterygii in jugular vein (UBERON:0004711)

relationship: part_of UBERON:0000974 {gci_filler="NCBITaxon:40674", gci_relation="in_taxon"} ! neck

anitacaron avatar Sep 04 '23 17:09 anitacaron

Looking at neck and the original ticket #2367, neck SubclassOf 'only in taxon' some Sarcopterygii doesn't seem correct, shouldn't we remove that axiom? Then we can add 'jugular vein' and ('in taxon' some Sarcopterygii) SubClassOf 'part of' some neck (not replacing the mammalian GCI). Therefore I suggest the following actions for this ticket:

  • [ ] Remove axiom neck SubclassOf 'only in taxon' some Sarcopterygii.
  • [ ] Add GCI 'jugular vein' and ('in taxon' some Sarcopterygii) SubClassOf 'part of' some neck.

@cmungall, do you agree with these edits?

aleixpuigb avatar Sep 05 '23 10:09 aleixpuigb

agreed

cmungall avatar Sep 07 '23 00:09 cmungall