First attempt adding taxon constraint QC back
Fixes #2374
@shawntanzk if you have time, can you check out this PR and add an xref that would (or should) definitely break the taxon constraints rules? Seems like the ZFA one that previously broke stuff doesn't today. Wanna make sure that something still breaks.
happy to, but not sure what this QC does and what I should be looking out for
Dont worry about the qc.. Just add a cross reference that would 100% break the rules, like a fishy reference to something that can only be in humans.
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.
Here's a diff of how these changes impact the classified ontology (on -simple file):
Ontology comparison
Left
- Ontology IRI:
http://purl.obolibrary.org/obo/uberon/uberon-simple.owl - Version IRI:
http://purl.obolibrary.org/obo/uberon/releases/2022-08-09/uberon-simple.owl - Loaded from:
file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl
Right
- Ontology IRI:
http://purl.obolibrary.org/obo/uberon/uberon-simple.owl - Version IRI:
http://purl.obolibrary.org/obo/uberon/releases/2022-08-09/uberon-simple.owl - Loaded from:
file:/work/src/ontology/uberon-simple.owl
Ontology imports
Ontology annotations
uterine horn http://purl.obolibrary.org/obo/UBERON_0002247
Added
- uterine horn database_cross_reference "ZFA:0005829"
Here's a diff of your edit file (unreasoned)
Ontology comparison
Left
- Ontology IRI:
http://purl.obolibrary.org/obo/uberon/core.owl - Version IRI: None
- Loaded from:
file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo
Right
- Ontology IRI:
http://purl.obolibrary.org/obo/uberon/core.owl - Version IRI: None
- Loaded from:
file:/work/src/ontology/uberon-edit.obo
Ontology imports
Ontology annotations
uterine horn http://purl.obolibrary.org/obo/UBERON_0002247
Added
- uterine horn database_cross_reference "ZFA:0005829"^^string
@matentzn - can I remove the fake ZFA xref now? Happy to update this to latest branch and if it passes stick the check back in :D
As opposed to all other PRs, this PR is only to be considered successful if it fails, not of it passes. Raise a future tech call, need someone to look why its not failing
wwhatttt ok yeah, it failed when i last looked, must have been something else
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.
Superseded by #2928