uberon icon indicating copy to clipboard operation
uberon copied to clipboard

First attempt adding taxon constraint QC back

Open matentzn opened this issue 3 years ago • 10 comments

Fixes #2374

matentzn avatar Apr 08 '22 12:04 matentzn

@shawntanzk if you have time, can you check out this PR and add an xref that would (or should) definitely break the taxon constraints rules? Seems like the ZFA one that previously broke stuff doesn't today. Wanna make sure that something still breaks.

matentzn avatar Apr 08 '22 12:04 matentzn

happy to, but not sure what this QC does and what I should be looking out for

shawntanzk avatar Apr 08 '22 12:04 shawntanzk

Dont worry about the qc.. Just add a cross reference that would 100% break the rules, like a fishy reference to something that can only be in humans.

matentzn avatar Apr 08 '22 12:04 matentzn

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

github-actions[bot] avatar May 09 '22 02:05 github-actions[bot]

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-09/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-09/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

uterine horn http://purl.obolibrary.org/obo/UBERON_0002247

Added

github-actions[bot] avatar Jul 22 '22 09:07 github-actions[bot]

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

uterine horn http://purl.obolibrary.org/obo/UBERON_0002247

Added

github-actions[bot] avatar Jul 22 '22 09:07 github-actions[bot]

@matentzn - can I remove the fake ZFA xref now? Happy to update this to latest branch and if it passes stick the check back in :D

shawntanzk avatar Aug 09 '22 14:08 shawntanzk

As opposed to all other PRs, this PR is only to be considered successful if it fails, not of it passes. Raise a future tech call, need someone to look why its not failing

matentzn avatar Aug 10 '22 09:08 matentzn

wwhatttt ok yeah, it failed when i last looked, must have been something else

shawntanzk avatar Aug 10 '22 10:08 shawntanzk

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

github-actions[bot] avatar Sep 10 '22 03:09 github-actions[bot]

Superseded by #2928

anitacaron avatar Sep 15 '23 10:09 anitacaron