uberon icon indicating copy to clipboard operation
uberon copied to clipboard

[Typo/Error] Synonym appears as both exact AND broad or related for the same term

Open ghost opened this issue 3 years ago • 12 comments

Uberon term Multiple terms. For example, https://www.ebi.ac.uk/ols/ontologies/uberon/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FUBERON_0013528 (and other Brodmann area terms).

Bug description There are several instances where the same synonym is used as both an exact synonym and a broad synonym for the same term. There are also instances where a synonym is annotated as both an exact and related synonym. For example, see UBERON_0013528 Brodmann (1909) area 11:

Screenshot 2022-02-14 at 09 32 34

In this case, the repeated synonyms probably should only be related to the term with the has_exact_synonym relationship.

These examples were discovered by spot checking and may represent a global issue of duplicate synonyms.

ghost avatar Feb 14 '22 15:02 ghost

Suggestion: whenever there is exact and something else - prefer something else? eg broad preferred When people come by any terms that they don't think is right, they should make a ticket

shawntanzk avatar Feb 21 '22 14:02 shawntanzk

https://github.com/monarch-initiative/mondo/tree/master/src/sparql/update <- can use SPARQL query from here and modify. Discuss in next CL/UBERON call and make decision on this

shawntanzk avatar Feb 21 '22 14:02 shawntanzk

whenever there is exact and something else - prefer something else? eg broad preferred

In the example that prompted this ticket, the exact duplicate synonyms should be retained and the broad and related synonyms removed.

ghost avatar Feb 21 '22 15:02 ghost

Also see https://github.com/obophenotype/uberon/issues/2053

paolaroncaglia avatar Feb 23 '22 17:02 paolaroncaglia

Action: change all to exact and create a PR for review

shawntanzk avatar Feb 28 '22 18:02 shawntanzk

Checking in on the status of this... not sure what "Icebox" is. Will the synonyms in question have to be fixed manually?

ghost avatar Apr 19 '22 09:04 ghost

@bvarner-ebi - its in icebox as it depends on discussions here https://github.com/obophenotype/uberon/issues/2363 will put it in the agenda for cl/uberon call

good job past Shawn, apparently already added it to agenda heh

shawntanzk avatar Apr 19 '22 09:04 shawntanzk

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

github-actions[bot] avatar Feb 15 '23 02:02 github-actions[bot]

Blocked by:

  • [ ] https://github.com/obophenotype/uberon/issues/2363

anitacaron avatar Feb 15 '23 08:02 anitacaron

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

github-actions[bot] avatar Aug 16 '23 01:08 github-actions[bot]

Blocked by:

@anitacaron, since the issue noted above is closed I removed the "blocked" label from this issue. Is there anything else that is required before getting this issue fixed?

ghost avatar Oct 18 '23 12:10 ghost

No action plan described. @anitacaron, please consider reassigning as appropriate.

ghost avatar Nov 17 '23 15:11 ghost