uberon icon indicating copy to clipboard operation
uberon copied to clipboard

Please revise UBERON:0001850 lacrimal drainage system

Open paola-scibite opened this issue 4 years ago • 2 comments

UBERON:0001850 lacrimal drainage system has an editor note "TODO - resolve lacrimal canaliculus vs larcimal duct" please see https://github.com/obophenotype/cell-ontology/issues/1392 for implications/consequences in CL too. Thanks!

paola-scibite avatar Dec 21 '21 10:12 paola-scibite

Dear Uberon and CL editors, No rush, but it'd be great if someone other than me could address this issue please, along with the related CL one. (I'll assign to myself for now so it doesn't get lost, but feel free to unassign!) Note that UBERON:0001850 'lacrimal drainage system' is applicable (restricted) to Tetrapoda, so the related anatomical terms should accommodate some non-mammalian vertebrates too. Thanks.

paolaroncaglia avatar Dec 21 '21 16:12 paolaroncaglia

This issue has not seen any activity in the past 6 months; it will be closed automatically in one year from now if no action is taken.

github-actions[bot] avatar Sep 01 '22 03:09 github-actions[bot]

This issue has been closed automatically because it has not been updated in 18 months. Please re-open if you still need this to be addressed.

github-actions[bot] avatar Sep 02 '23 01:09 github-actions[bot]

@bvarner-ebi, could you have a look into this, please? 😄

anitacaron avatar Sep 04 '23 17:09 anitacaron

Below are some notes and proposed edits. CC @cmungall who is a dbxref for the text definitions of some of the terms noted below.

Synonyms

  • "lacrimal duct" is a related synonym of 'lacrimal drainage system'. Agree, no change. Of note, the definition of synonym dbxref FMA:61063 ‘Lacrimal duct’ seems to exclude excretory lacrimal ducts, which aligns with the definitions of ‘lacrimal canaliculus’ and ‘nasolacrimal duct’.

  • [x] Add "lacrimal duct" as a related synonym of 'lacrimal canaliculus'; dbxrefs: ISBN:1587341026; https://www.bartleby.com/lit-hub/anatomy-of-the-human-body/fig-896/

  • [x] Add "lacrimal duct" as a related synonym of 'nasolacrimal duct'; dbxref: PMID:30285382

Definitions

  • CL:1000433 'epithelial cell of lacrimal canaliculus' 
Equivalent to
 epithelial cell and part of some lacrimal canaliculus Agree, no change.

  • CL:1000435 'epithelial cell of lacrimal duct' 
Equivalent to 
non-branched duct epithelial cell and part of some lacrimal drainage systemProposed changes: 
 
- [x] Relabel 'epithelial cell of lacrimal duct' to 'epithelial cell of lacrimal drainage system' 
- [x] Add "epithelial cell of lacrimal duct” (the current label) as a related synonym. 
- [x] Change logical defintion to: 
Equivalent to
 ‘duct epithelial cell’ and part of some 'lacrimal drainage system' 
- [x] Update text def: 
CURRENT: "An epithelial cell that is part of the lacrimal duct." 
PROPOSED: "An epithelial cell that is part of the lacrimal drainage system."

Miscellaneous

  • [x] Remove editor note from 'lacrimal drainage system' and 'lacrimal canaliculus'

  • Consider obsoleting the following and move current classes under 'duct epithelial cell':

branched duct epithelial cell’ ‘non-branched duct epithelial cell

  • Consider adding new Uberon term 'excretory lacrimal duct'

ghost avatar Sep 05 '23 12:09 ghost

@paola-scibite - could you comment on @bvarner-ebi 's comment?

dosumis avatar Oct 19 '23 14:10 dosumis

CC @cmungall

dosumis avatar Oct 19 '23 14:10 dosumis

I agree with @bvarner-ebi's proposed changes

cmungall avatar Oct 19 '23 18:10 cmungall

Thank you @bvarner-ebi , @dosumis and @cmungall . The proposed changes sound good to me too. Best wishes!

paola-scibite avatar Oct 20 '23 14:10 paola-scibite

Edits addressed in this issue:

  • [x] Add "lacrimal duct" as a related synonym of 'lacrimal canaliculus'; dbxrefs: ISBN:1587341026; https://www.bartleby.com/lit-hub/anatomy-of-the-human-body/fig-896/

  • [x] Add "lacrimal duct" as a related synonym of 'nasolacrimal duct'; dbxref: PMID:30285382

  • [x] Remove editor note from 'lacrimal drainage system' and 'lacrimal canaliculus'

  • CL edits to be addressed in cell-ontology: https://github.com/obophenotype/cell-ontology/issues/2224

ghost avatar Nov 17 '23 15:11 ghost