uberon icon indicating copy to clipboard operation
uberon copied to clipboard

UBERON base approach

Open anitacaron opened this issue 4 years ago • 2 comments

Fixes #2094

anitacaron avatar Dec 07 '21 15:12 anitacaron

This is very good work @anitacaron

Unfortunately, we need to really dig into uberon.Makefile as well, and I wont have time to do that before I leave now.

Please add this PR to the project board and make sure we revisit it again on Feburary next year.

Action items:

  • [ ] Understand which special "imports" goals from uberon.Makefile can be ditched. Right now, all of them, AND the mirrors, are overwritten by ideosyncratic code. Dealing with this will lead to a significant cleanup of Uberon Makefile, but is not easy.
  • [ ] Create a "published" module, as the merged module as is will likely make uberon.owl too large for GitHub.

Please remind me of this PR in our first meeting in February! Thank you!

matentzn avatar Dec 08 '21 12:12 matentzn

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

github-actions[bot] avatar Mar 17 '22 02:03 github-actions[bot]

@anitacaron what is the state of this branch - did we add the role chain back again? If not, lets prioritise during next call!

matentzn avatar Nov 28 '22 12:11 matentzn

This morning I added the property chain and generated another diff https://github.com/obophenotype/uberon/issues/2664#issuecomment-1328986014

anitacaron avatar Nov 28 '22 13:11 anitacaron

@anitacaron when you tried adding the role chain to the role chains component, also make sure that uberon-simple.owl actually depends on tmp/materialized! Maybe this materialised goal should mostly be moved to tmp/uberon-edit.owl..

matentzn avatar Nov 29 '22 09:11 matentzn

Hmm, maybe that's why when I moved the property chain from the edit to the component, it got the same diff as previously.

anitacaron avatar Nov 29 '22 09:11 anitacaron

#gogoeditdiff

matentzn avatar Dec 09 '22 14:12 matentzn

We imported the component with the properties chains for develops_from in the edit file. This will have the same reasoning result, but they will not be included in the base file.

anitacaron avatar Dec 12 '22 12:12 anitacaron

Finally, it's ready for final review and to be merged.

anitacaron avatar Dec 16 '22 18:12 anitacaron

I returned the imports in the catalogue needed for the composite-metazoan and composite-vertebrate.

anitacaron avatar Dec 19 '22 15:12 anitacaron

I ran an offline release to ensure all imports were in the catalogue.

anitacaron avatar Jan 04 '23 18:01 anitacaron