uberon icon indicating copy to clipboard operation
uberon copied to clipboard

Regenerated allen atlases

Open cmungall opened this issue 7 years ago • 6 comments

Note there is a spurious diff in here - it makes it look like some IDs were deleted; just order shuffling (sorry, should have normalized ordering)

cmungall avatar Mar 06 '18 01:03 cmungall

Who would be an appropriate reviewer for this PR? @cmungall

matentzn avatar Nov 18 '19 09:11 matentzn

@tgbugs or @dosumis. I simply forget what the current status is with IDs and the Allen Atlases

cmungall avatar Dec 13 '19 03:12 cmungall

The MBA changes look ok to me. The ids are more or less completely arbitrary at this point (much to the consternation of some atlas implementers), still no change to the fact that all the ontology ids share the same uri prefix in the Allen api (http://api.brain-map.org/api/v2/data/Structure/).

tgbugs avatar Dec 13 '19 04:12 tgbugs

If to be moved forward needs to be aligned with new Makefile structure. Can help but needs driver.

matentzn avatar Jul 21 '21 09:07 matentzn

ABA Uberon mappings are important for the Brain Data Standards grant, so work can be done @hkir-dev (+ Shawn & Allen representatives if needed). This is currently low on our priority list so won't happen straight away. We should organise a call to work out what needs to be done. Can be after summer.

dosumis avatar Jul 21 '21 09:07 dosumis

Presumably we can close here?

For all 5 Allen atlases (HBA / DHBA / MBA / DMBA / PBA) that we include in composite-metazoan, we now use the pre-built ontologies provided by https://github.com/brain-bican, so there’s no more need to re-generate them ourselves.

As for the addition of the “glioblastoma” atlas:

  • Is it really something that should be included in composite-metazoan? My feeling is that Uberon (and its composite products) should only be about “normal” / “wild-type” anatomy, and that describing pathological anatomical structures does not belong here.
  • In this PR, allen-glioblastoma.obo is constructed exactly as allen-hba.obo – both files are constructed from the same JSON file: http://api.brain-map.org/api/v2/structure_graph_download/10.json – I assume this is a mistake?

gouttegd avatar Dec 07 '23 16:12 gouttegd